Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1799)

Unified Diff: chrome/browser/ui/app_list/app_list_service_mac.mm

Issue 1951783002: Remove --enable-mac-views-app-list on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gn on not mac Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_service_mac.mm
diff --git a/chrome/browser/ui/app_list/app_list_service_mac.mm b/chrome/browser/ui/app_list/app_list_service_mac.mm
index 386b3b31a9248b159387eafb256eb0e9221b5970..a38f753f220f111e62cc0498ed87c8627c0ad925 100644
--- a/chrome/browser/ui/app_list/app_list_service_mac.mm
+++ b/chrome/browser/ui/app_list/app_list_service_mac.mm
@@ -266,17 +266,6 @@ void GetAppListWindowOrigins(
start_origin);
}
-AppListServiceMac* GetActiveInstance() {
- if (app_list::switches::IsMacViewsAppListEnabled()) {
-#if defined(TOOLKIT_VIEWS)
- // TODO(tapted): Return AppListServiceViewsMac instance.
-#else
- NOTREACHED();
-#endif
- }
- return AppListServiceCocoaMac::GetInstance();
-}
-
} // namespace
AppListServiceMac::AppListServiceMac() {
@@ -512,13 +501,14 @@ void AppListServiceMac::WindowAnimationDidEnd() {
// static
AppListService* AppListService::Get() {
- return GetActiveInstance();
+ return AppListServiceCocoaMac::GetInstance();
}
// static
void AppListService::InitAll(Profile* initial_profile,
const base::FilePath& profile_path) {
- GetActiveInstance()->InitWithProfilePath(initial_profile, profile_path);
+ AppListServiceCocoaMac::GetInstance()->InitWithProfilePath(initial_profile,
msw 2016/05/05 01:51:06 nit: just call Get()?
tapted 2016/05/05 02:53:42 Hehe - I tried that _ages_ ago, but this one has t
+ profile_path);
}
@implementation AppListAnimationController
@@ -583,10 +573,9 @@ void AppListService::InitAll(Profile* initial_profile,
- (void)animationDidEnd:(NSAnimation*)animation {
content::BrowserThread::PostTask(
- content::BrowserThread::UI,
- FROM_HERE,
+ content::BrowserThread::UI, FROM_HERE,
base::Bind(&AppListServiceMac::WindowAnimationDidEnd,
- base::Unretained(GetActiveInstance())));
+ base::Unretained(AppListServiceCocoaMac::GetInstance())));
msw 2016/05/05 01:51:06 nit: just call AppListService::Get()?
tapted 2016/05/05 02:53:42 see above
}
@end

Powered by Google App Engine
This is Rietveld 408576698