Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 1951683002: mus/chrome: Remove incorrect deps on mus from chrome_manifest. (Closed)

Created:
4 years, 7 months ago by sadrul
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus/chrome: Remove incorrect deps on mus from chrome_manifest. BUG=none R=sky@chromium.org Committed: https://crrev.com/241f609de8387e8389e2ba19c329cf3ad6651eb3 Cr-Commit-Position: refs/heads/master@{#391433}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/app/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sadrul
4 years, 7 months ago (2016-05-03 23:09:46 UTC) #1
sky
LGTM
4 years, 7 months ago (2016-05-03 23:31:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951683002/1
4 years, 7 months ago (2016-05-03 23:33:51 UTC) #4
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-05-04 00:46:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951683002/1
4 years, 7 months ago (2016-05-04 01:01:07 UTC) #8
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-05-04 01:06:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951683002/10002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951683002/10002
4 years, 7 months ago (2016-05-04 01:14:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:10002)
4 years, 7 months ago (2016-05-04 03:15:41 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 03:17:57 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/241f609de8387e8389e2ba19c329cf3ad6651eb3
Cr-Commit-Position: refs/heads/master@{#391433}

Powered by Google App Engine
This is Rietveld 408576698