Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1951673002: Add GYP support for packaged manifests (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GYP support for packaged manifests Also hooks up mojo:user to exe:content_browser's manifest in GYP builds. BUG=608121 Committed: https://crrev.com/02dd0a2c25d9ace3cac32ea5cc9e5c1c45371d22 Cr-Commit-Position: refs/heads/master@{#391500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M content/content.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/mojo_application_manifest.gypi View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-03 23:07:10 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 7 months ago (2016-05-03 23:10:09 UTC) #3
michaeln
lgtm 2, the mojodomstorage tests pass with it patched in. There may be another missing ...
4 years, 7 months ago (2016-05-04 00:49:29 UTC) #4
Ken Rockot(use gerrit already)
On 2016/05/04 at 00:49:29, michaeln wrote: > lgtm 2, the mojodomstorage tests pass with it ...
4 years, 7 months ago (2016-05-04 03:23:19 UTC) #5
Ben Goodger (Google)
On 2016/05/04 03:23:19, Ken Rockot wrote: > On 2016/05/04 at 00:49:29, michaeln wrote: > > ...
4 years, 7 months ago (2016-05-04 03:57:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951673002/1
4 years, 7 months ago (2016-05-04 14:03:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 14:07:27 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 14:08:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02dd0a2c25d9ace3cac32ea5cc9e5c1c45371d22
Cr-Commit-Position: refs/heads/master@{#391500}

Powered by Google App Engine
This is Rietveld 408576698