Issue 195163004: Fix SkOffsetImageFilter to use a temporary for bounds computations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195163004: Fix SkOffsetImageFilter to use a temporary for bounds computations. (Closed)

Created:
6 years, 9 months ago by Stephen White

Modified:
6 years, 9 months ago

Reviewers:
sugoi1, sugoi

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix SkOffsetImageFilter to use a temporary for bounds computations. SkOffsetImageFilter::onFilterBounds() was writing to *dst, and later referring to src. These may be the same memory location, so the results were incorrect. Covered by the 5th test case in offsetimagefilter. BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=13744

Patch Set 1 #

Patch Set 2 : Fix expectations #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	expectations/gm/ignored-tests.txt	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/effects/SkOffsetImageFilter.cpp	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sugoi

On 2014/03/11 17:57:39, Stephen White wrote: > sugoi: PTAL. Thanks! LGTM

6 years, 9 months ago (2014-03-11 18:01:57 UTC) #2

Stephen White

6 years, 9 months ago (2014-03-11 18:29:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r13744 (presubmit successful).

Expand Messages | Collapse Messages