src/objects.cc - Issue 195163002: fix bad access check check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 195163002: fix bad access check check (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index cd86a43988d98e2f3cab15831d2e6144f28ae886..8a0dda4d522c7456c8577de7f6e3ac1e1688f2a9 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -5914,6 +5914,7 @@ bool JSReceiver::IsSimpleEnum() {

JSObject* curr = JSObject::cast(o);

int enum_length = curr->map()->EnumLength();

if (enum_length == kInvalidEnumCacheSentinel) return false;

+ if (curr->IsJSGlobalProxy() && curr->IsAccessCheckNeeded()) return false;

Toon Verwaest 2014/03/11 14:39:58 We'll need to remove the ASSERT below and just do

ASSERT(!curr->HasNamedInterceptor());

ASSERT(!curr->HasIndexedInterceptor());

ASSERT(!curr->IsAccessCheckNeeded());