Issue 195163002: fix bad access check check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195163002: fix bad access check check (Closed)

Created:
6 years, 9 months ago by dcarney

Modified:
6 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

fix bad access check check R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19804

Patch Set 4 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	src/objects.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-351262.js	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

LGTM with comment https://codereview.chromium.org/195163002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/195163002/diff/1/src/objects.cc#newcode5917 src/objects.cc:5917: if (curr->IsJSGlobalProxy() && curr->IsAccessCheckNeeded()) return false; ...

6 years, 9 months ago (2014-03-11 14:39:58 UTC) #1

Toon Verwaest

https://codereview.chromium.org/195163002/diff/1/test/mjsunit/regress/regress-crbug-351262.js File test/mjsunit/regress/regress-crbug-351262.js (right): https://codereview.chromium.org/195163002/diff/1/test/mjsunit/regress/regress-crbug-351262.js#newcode26 test/mjsunit/regress/regress-crbug-351262.js:26: // OF THIS SOFTWARE, EVEN IF ADVISED OF THE ...

6 years, 9 months ago (2014-03-11 14:40:19 UTC) #2

dcarney

6 years, 9 months ago (2014-03-11 15:12:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r19804 (presubmit successful).

Expand Messages | Collapse Messages

Issue 195163002: fix bad access check check (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages