Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1951593002: Add MD Ink Drop to host only when a ripple/hover is active. (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Add MD Ink Drop to host only when a ripple/hover is active. In order to paint the material design ink drop behind button icons the icon View and the button View have to paint to their own Layers. There is no need to incur the additional expense of these Layers unless the ink drop ripple or hover is actually active on the View. BUG=604415 TEST=InkDropHoverTest.* TEST=InkDropAnimationControllerImplTest.* TEST=InkDropAnimationControllerFactoryTest.VerifyInkDropLayersRemovedAfterDestructionWhenHoverIsActive Review-Url: https://codereview.chromium.org/1897073002 Cr-Commit-Position: refs/heads/master@{#390696} (cherry picked from commit 741be72a4d24789a876d87d0d94e9e2e1cdcd674) Committed: https://chromium.googlesource.com/chromium/src/+/b597394a728de58aca50b199fa08b61787426682

Patch Set 1 #

Patch Set 2 : Replaced unique_ptr with scoped_ptr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -41 lines) Patch
M ui/views/animation/ink_drop_animation_controller_factory_unittest.cc View 1 chunk +9 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.h View 5 chunks +19 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.cc View 5 chunks +41 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl_unittest.cc View 1 chunk +100 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_hover.h View 4 chunks +14 lines, -4 lines 0 comments Download
M ui/views/animation/ink_drop_hover.cc View 5 chunks +21 lines, -3 lines 0 comments Download
A ui/views/animation/ink_drop_hover_observer.h View 1 chunk +41 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_hover_unittest.cc View 1 2 chunks +104 lines, -20 lines 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_animation_observer.h View 1 chunk +1 line, -1 line 0 comments Download
A ui/views/animation/test/test_ink_drop_hover_observer.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ui/views/animation/test/test_ink_drop_hover_observer.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
4 years, 7 months ago (2016-05-03 21:48:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b597394a728de58aca50b199fa08b61787426682.

Powered by Google App Engine
This is Rietveld 408576698