Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(109)

Issue 1951573002: Replace IFX_MemoryAllocator::Release() with delete. (Closed)

Created:
4 years, 5 months ago by Tom Sepez
Modified:
4 years, 5 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace IFX_MemoryAllocator::Release() with delete. All Release() did was invoke delete. Add some "overrides" while we're at it. Committed: https://pdfium.googlesource.com/pdfium/+/2a14bde1011a5d374d1109fd83f59a8ff67c162e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -41 lines) Patch
M xfa/fde/css/fde_cssstyleselector.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fee/fde_txtedtbuf.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M xfa/fgas/crt/fgas_memory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fgas/crt/fgas_memory.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, for review.
4 years, 5 months ago (2016-05-03 21:24:35 UTC) #2
dsinclair
lgtm
4 years, 5 months ago (2016-05-04 13:13:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951573002/1
4 years, 5 months ago (2016-05-04 13:13:32 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-05-04 13:13:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/2a14bde1011a5d374d1109fd83f59a8ff67c...

Powered by Google App Engine
This is Rietveld 408576698