Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1951523002: Add basic support for launching mash shelf pinned apps. (Closed)

Created:
4 years, 7 months ago by msw
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add basic support for launching mash shelf pinned apps. Keep the mojo ShelfItemDelegate in ShelfItemDelegateMus. Use this to call the new LaunchItem() interface function. Move app launching functionality to LauncherControllerHelper. Use this in ChromeMashShelfController too (w/new helper member). BUG=557406 TEST=Can launch some profile-pinned mash shelf items (eg. Chrome Web Store). R=sky@chromium.org Committed: https://crrev.com/e0d5b8cd941e967ec47a3d0317a858d0f735943c Cr-Commit-Position: refs/heads/master@{#391391}

Patch Set 1 #

Patch Set 2 : Only LaunchItem with no windows; otherwise kNoAction (for CreateApplicationMenu). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -85 lines) Patch
M ash/mus/shelf_delegate_mus.cc View 1 5 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 5 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 6 chunks +1 line, -64 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.h View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc View 7 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_controller_helper.h View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_controller_helper.cc View 5 chunks +71 lines, -3 lines 0 comments Download
M mash/shelf/public/interfaces/shelf.mojom View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 7 months ago (2016-05-03 20:48:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951523002/20001
4 years, 7 months ago (2016-05-03 20:48:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 21:43:38 UTC) #6
sky
LGTM
4 years, 7 months ago (2016-05-03 22:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951523002/20001
4 years, 7 months ago (2016-05-03 22:34:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 23:20:42 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 23:21:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0d5b8cd941e967ec47a3d0317a858d0f735943c
Cr-Commit-Position: refs/heads/master@{#391391}

Powered by Google App Engine
This is Rietveld 408576698