Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1951503002: MD Settings: <settings-dialog>, restore focus effect for the cancel button. (Closed)

Created:
4 years, 7 months ago by dpapad
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: <settings-dialog>, restore focus effect for the cancel button. BUG=608618 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/33bb44e0acccaf4aef4cf9342ae3f5eb9dce856d Cr-Commit-Position: refs/heads/master@{#391688}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Stop using keyboard-focus. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_dialog.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
dpapad
keyboard-focus CSS class specifies "font-weight: bold", but it was being accidentally overriden.
4 years, 7 months ago (2016-05-03 19:00:07 UTC) #3
Dan Beam
drive-by https://codereview.chromium.org/1951503002/diff/1/chrome/browser/resources/settings/settings_dialog.html File chrome/browser/resources/settings/settings_dialog.html (right): https://codereview.chromium.org/1951503002/diff/1/chrome/browser/resources/settings/settings_dialog.html#newcode73 chrome/browser/resources/settings/settings_dialog.html:73: :host ::content .button-container .cancel-button:not(.keyboard-focus) { i don't think ...
4 years, 7 months ago (2016-05-03 19:06:28 UTC) #4
dpapad
On 2016/05/03 at 19:06:28, dbeam wrote: > drive-by > > https://codereview.chromium.org/1951503002/diff/1/chrome/browser/resources/settings/settings_dialog.html > File chrome/browser/resources/settings/settings_dialog.html (right): ...
4 years, 7 months ago (2016-05-03 19:25:36 UTC) #5
dpapad
On 2016/05/03 at 19:25:36, dpapad wrote: > On 2016/05/03 at 19:06:28, dbeam wrote: > > ...
4 years, 7 months ago (2016-05-04 00:14:42 UTC) #6
dpapad
On 2016/05/04 at 00:14:42, dpapad wrote: > On 2016/05/03 at 19:25:36, dpapad wrote: > > ...
4 years, 7 months ago (2016-05-04 20:20:45 UTC) #7
dschuyler
lgtm
4 years, 7 months ago (2016-05-04 22:17:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951503002/20001
4 years, 7 months ago (2016-05-04 22:29:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 23:30:00 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 23:31:26 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33bb44e0acccaf4aef4cf9342ae3f5eb9dce856d
Cr-Commit-Position: refs/heads/master@{#391688}

Powered by Google App Engine
This is Rietveld 408576698