Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2052)

Unified Diff: net/base/tcp_client_socket.h

Issue 19515: In rare cases (when running inside QEMU), the event... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/tcp_client_socket_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/tcp_client_socket.h
===================================================================
--- net/base/tcp_client_socket.h (revision 8904)
+++ net/base/tcp_client_socket.h (working copy)
@@ -86,6 +86,14 @@
// base::ObjectWatcher::Delegate methods:
virtual void OnObjectSignaled(HANDLE object);
+ // After a Winsock function succeeds synchronously, waits for the
eroman 2009/01/30 21:44:46 This should probably be wrapped in a: #if defined
wtc 2009/01/30 21:48:06 Yes, this is a Windows-specific method. It is alr
eroman 2009/01/30 21:55:17 Oh right, didn't notice! LGTM.
+ // (manual-reset) event object to become signaled and resets it.
+ //
+ // Our testing shows that except in rare cases (when running inside QEMU),
+ // the event object is already signaled at this point, so we just call this
+ // method on the IO thread to avoid a context switch.
+ void WaitForAndResetEvent();
+
OVERLAPPED overlapped_;
WSABUF buffer_;
« no previous file with comments | « no previous file | net/base/tcp_client_socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698