In rare cases (when running inside QEMU), the event...

net/base/tcp_client_socket.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_TCP_CLIENT_SOCKET_H_
 #define NET_BASE_TCP_CLIENT_SOCKET_H_
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
@@ skipping 68 matching lines @@
     NOT_WAITING,
     WAITING_CONNECT,
     WAITING_READ,
     WAITING_WRITE
   };
   WaitState wait_state_;
 
   // base::ObjectWatcher::Delegate methods:
   virtual void OnObjectSignaled(HANDLE object);
 
+  // After a Winsock function succeeds synchronously, waits for the

[eroman, 2009/01/30 21:44:46]

This should probably be wrapped in a:

#if defined (OS_WIN)
...
#endif

Unless it will be implemented on other platforms.

[wtc, 2009/01/30 21:48:06]

Yes, this is a Windows-specific method.  It is already wrapped in a #if
defined(OS_WIN).

[eroman, 2009/01/30 21:55:17]

Oh right, didn't notice!

LGTM.

+  // (manual-reset) event object to become signaled and resets it.
+  //
+  // Our testing shows that except in rare cases (when running inside QEMU),
+  // the event object is already signaled at this point, so we just call this
+  // method on the IO thread to avoid a context switch.
+  void WaitForAndResetEvent();
+
   OVERLAPPED overlapped_;
   WSABUF buffer_;
 
   base::ObjectWatcher watcher_;
 
   void DidCompleteIO();
 #elif defined(OS_POSIX)
   // Whether we're currently waiting for connect() to complete
   bool waiting_connect_;
 
@@ skipping 25 matching lines @@
 
   int CreateSocket(const struct addrinfo* ai);
   void DoCallback(int rv);
   void DidCompleteConnect();
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_TCP_CLIENT_SOCKET_H_