Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Issue 1951463002: Add SK_API to SkFontLCDConfig. (Closed)

Created:
4 years, 7 months ago by bungeman-skia
Modified:
4 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SK_API to SkFontLCDConfig. This will allow transition from double deprecated SkFontHost. TBR=reed This is obviously needed to remove other code. Committed: https://skia.googlesource.com/skia/+/68f7460fd18357a81a3d4243f1a798f0d64b621e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkFontLCDConfig.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
bungeman-skia
4 years, 7 months ago (2016-05-03 18:11:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951463002/1
4 years, 7 months ago (2016-05-03 18:11:47 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-03 18:11:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/9359)
4 years, 7 months ago (2016-05-03 18:13:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951463002/1
4 years, 7 months ago (2016-05-03 18:55:11 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:56:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/68f7460fd18357a81a3d4243f1a798f0d64b621e

Powered by Google App Engine
This is Rietveld 408576698