base/task_scheduler/scheduler_thread_pool_impl_unittest.cc - Issue 1951453002: Name TaskScheduler's worker threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

Issue 1951453002: Name TaskScheduler's worker threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b7_fdoray_fixtracing

Patch Set: explicit cast to int Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

diff --git a/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc b/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

index 8ab4e176bc3e94367d585004772afc70e74618c7..8af2c52ffeaffb4cf69ad8ac0d791d517f824bc5 100644

--- a/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

+++ b/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

@@ -63,7 +63,8 @@ class TaskSchedulerThreadPoolImplTest

void SetUp() override {

thread_pool_ = SchedulerThreadPoolImpl::Create(

- ThreadPriority::NORMAL, kNumThreadsInThreadPool, IORestriction::ALLOWED,

+ "TestThreadPoolWithFileIO", ThreadPriority::NORMAL,

+ kNumThreadsInThreadPool, IORestriction::ALLOWED,

Bind(&TaskSchedulerThreadPoolImplTest::ReEnqueueSequenceCallback,

Unretained(this)),

&task_tracker_, &delayed_task_manager_);

@@ -359,7 +360,7 @@ TEST_P(TaskSchedulerThreadPoolImplIORestrictionTest, IORestriction) {

DelayedTaskManager delayed_task_manager(Bind(&DoNothing));

auto thread_pool = SchedulerThreadPoolImpl::Create(

- ThreadPriority::NORMAL, 1U, GetParam(),

+ "TestThreadPoolWithParam", ThreadPriority::NORMAL, 1U, GetParam(),

Bind(&NotReachedReEnqueueSequenceCallback), &task_tracker,

&delayed_task_manager);

ASSERT_TRUE(thread_pool);