Name TaskScheduler's worker threads

base/task_scheduler/task_scheduler_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/task_scheduler/task_scheduler_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 72 matching lines @@
       re_enqueue_sequence_callback =
           Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this));
 
   // TODO(fdoray): Derive the number of threads per pool from hardware
   // characteristics rather than using hard-coded constants.
 
   // Passing pointers to objects owned by |this| to
   // SchedulerThreadPoolImpl::Create() is safe because a TaskSchedulerImpl can't
   // be deleted before all its thread pools have been joined.
   background_thread_pool_ = SchedulerThreadPoolImpl::Create(
-      ThreadPriority::BACKGROUND, 1u, IORestriction::DISALLOWED,
-      re_enqueue_sequence_callback, &task_tracker_, &delayed_task_manager_);
+      "TaskSchedulerBackground", ThreadPriority::BACKGROUND, 1u,
+      IORestriction::DISALLOWED, re_enqueue_sequence_callback, &task_tracker_,
+      &delayed_task_manager_);
   CHECK(background_thread_pool_);
 
   background_file_io_thread_pool_ = SchedulerThreadPoolImpl::Create(
-      ThreadPriority::BACKGROUND, 1u, IORestriction::ALLOWED,
-      re_enqueue_sequence_callback, &task_tracker_, &delayed_task_manager_);
+      "TaskSchedulerBackgroundFileIO", ThreadPriority::BACKGROUND, 1u,
+      IORestriction::ALLOWED, re_enqueue_sequence_callback, &task_tracker_,
+      &delayed_task_manager_);
   CHECK(background_file_io_thread_pool_);
 
   normal_thread_pool_ = SchedulerThreadPoolImpl::Create(
-      ThreadPriority::NORMAL, 4u, IORestriction::DISALLOWED,
-      re_enqueue_sequence_callback, &task_tracker_, &delayed_task_manager_);
+      "TaskSchedulerForeground", ThreadPriority::NORMAL, 4u,
+      IORestriction::DISALLOWED, re_enqueue_sequence_callback, &task_tracker_,
+      &delayed_task_manager_);
   CHECK(normal_thread_pool_);
 
   normal_file_io_thread_pool_ = SchedulerThreadPoolImpl::Create(
-      ThreadPriority::NORMAL, 12u, IORestriction::ALLOWED,
-      re_enqueue_sequence_callback, &task_tracker_, &delayed_task_manager_);
+      "TaskSchedulerForegroundFileIO", ThreadPriority::NORMAL, 12u,

[fdoray, 2016/05/03 19:01:50]

Add a verification in VerifyTaskEnvironment in task_scheduler_impl_unittest.cc?

[gab, 2016/05/04 18:11:37]

Done though I'm afraid it's a bit too much of a white-box test, PTAL and let me
know what you think.

+      IORestriction::ALLOWED, re_enqueue_sequence_callback, &task_tracker_,
+      &delayed_task_manager_);
   CHECK(normal_file_io_thread_pool_);
 }
 
 SchedulerThreadPool* TaskSchedulerImpl::GetThreadPoolForTraits(
     const TaskTraits& traits) {
   if (traits.with_file_io()) {
     if (traits.priority() == TaskPriority::BACKGROUND)
       return background_file_io_thread_pool_.get();
     return normal_file_io_thread_pool_.get();
   }
@@ skipping 14 matching lines @@
   // with the highest priority in |sequence| as opposed to the next task's
   // specific priority.
   traits.WithPriority(sort_key.priority());
 
   GetThreadPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence),
                                                     sort_key);
 }
 
 }  // namespace internal
 }  // namespace base