Add global compile tool

Add global compile tool

This is for testing purposes and hence in tool.  Gives a dart2js-ish
API to invoke DDC, but stuffs everything in one module.

Closed https://codereview.chromium.org/1900813002/ in favor of this.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/f275993234de8e0fbda3c78afda5c6d1e6c73b82

[vsm, 2016-05-03 17:35:06]

Description was changed from

==========
Add global compile tool

This is for testing purposes and hence in tool.  Gives a dart2js-ish
API to invoke DDC, but stuffs everything in one module.
==========

to

==========
Add global compile tool

This is for testing purposes and hence in tool.  Gives a dart2js-ish
API to invoke DDC, but stuffs everything in one module.

Closed https://codereview.chromium.org/1900813002/ in favor of this.
==========

[vsm, 2016-05-03 17:35:06]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-05-03 21:25:49]

LGTM, but note that if you just want a single output JS, a much better strategy
would be find units (either packages, or minimal library cycles--easy to find
with LibraryElement it has the property right there for other libs in cycle) and
then link the resulting output together. 

As it is, this will pretty much hit every possible worst case behavior.

https://codereview.chromium.org/1951433002/diff/1/tool/global_compile.dart
File tool/global_compile.dart (right):

https://codereview.chromium.org/1951433002/diff/1/tool/global_compile.dart#ne...
tool/global_compile.dart:20: ..addFlag('unsafe-force-compile', negatable: false)
could you just reuse all existing flags? e.g.

import "package:dev_compiler/src/compiler/compiler.dart" show CompilerOptions.

then CompilerOptions.addArguments(parser);

similarly AnalyzerOptions.

https://codereview.chromium.org/1951433002/diff/1/tool/global_compile.dart#ne...
tool/global_compile.dart:52: transitiveFiles(inputSet, context, entry,
Directory.current.path);
consider: grouping by package, then linking output

that would produce much saner output. And be less likely to OOM the compiler or
hit other bad worst-case behavior :). it's not really designed to treat the
entire world as input.

[vsm, 2016-05-04 15:57:14]

On 2016/05/03 21:25:49, John Messerly wrote:
> LGTM, but note that if you just want a single output JS, a much better
strategy
> would be find units (either packages, or minimal library cycles--easy to find
> with LibraryElement it has the property right there for other libs in cycle)
and
> then link the resulting output together. 
> 
> As it is, this will pretty much hit every possible worst case behavior.
> 
> https://codereview.chromium.org/1951433002/diff/1/tool/global_compile.dart
> File tool/global_compile.dart (right):
> 
>
https://codereview.chromium.org/1951433002/diff/1/tool/global_compile.dart#ne...
> tool/global_compile.dart:20: ..addFlag('unsafe-force-compile', negatable:
false)
> could you just reuse all existing flags? e.g.

I don't want to allow all flags yet.  E.g., source maps are non-sensical with
how I'm concatenating and as is any other module format.

> 
> import "package:dev_compiler/src/compiler/compiler.dart" show CompilerOptions.
> 
> then CompilerOptions.addArguments(parser);
> 
> similarly AnalyzerOptions.
> 
>
https://codereview.chromium.org/1951433002/diff/1/tool/global_compile.dart#ne...
> tool/global_compile.dart:52: transitiveFiles(inputSet, context, entry,
> Directory.current.path);
> consider: grouping by package, then linking output
> 
> that would produce much saner output. And be less likely to OOM the compiler
or
> hit other bad worst-case behavior :). it's not really designed to treat the
> entire world as input.

Thanks.  Landing and iterating.

[vsm, 2016-05-04 15:57:41]

Description was changed from

==========
Add global compile tool

This is for testing purposes and hence in tool.  Gives a dart2js-ish
API to invoke DDC, but stuffs everything in one module.

Closed https://codereview.chromium.org/1900813002/ in favor of this.
==========

to

==========
Add global compile tool

This is for testing purposes and hence in tool.  Gives a dart2js-ish
API to invoke DDC, but stuffs everything in one module.

Closed https://codereview.chromium.org/1900813002/ in favor of this.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/f275993234de8e0fbda3c78afda5...
==========

[vsm, 2016-05-04 15:57:43]

Committed patchset #1 (id:1) manually as
f275993234de8e0fbda3c78afda5c6d1e6c73b82 (presubmit successful).