src/ia32/full-codegen-ia32.cc - Issue 19514004: In MacroAssembler::JumpIfNotBothSequentialAsciiStrings a custom mask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 19514004: In MacroAssembler::JumpIfNotBothSequentialAsciiStrings a custom mask (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Update after comments with fixes Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 66a7c1c080d6acc5271abdff1bf63095ab87b757..8f11acc1becd23be529a569f443f0b8fa1a8c427 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -4045,7 +4045,7 @@ void FullCodeGenerator::EmitFastAsciiArrayJoin(CallRuntime* expr) {

__ movzx_b(scratch, FieldOperand(scratch, Map::kInstanceTypeOffset));

__ and_(scratch, Immediate(

kIsNotStringMask | kStringEncodingMask | kStringRepresentationMask));

- __ cmp(scratch, ASCII_STRING_TYPE);

+ __ cmp(scratch, kStringTag | kOneByteStringTag | kSeqStringTag);

__ j(not_equal, &bailout);

// Add (separator length times array_length) - separator length

« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »