Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1951383002: Only set memory tool define if not set. (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Only set memory tool define if not set. This fixes a build issue where MEMORY_TOOL_REPLACES_ALLOCATOR may already be set. Committed: https://pdfium.googlesource.com/pdfium/+/1f00dbf0203bdd6b4100457301fef1216546e2f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M xfa/fgas/crt/fgas_memory.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL. Although, should I actually rename this to PDF_MEMORY... as we maybe enabling it for ...
4 years, 7 months ago (2016-05-05 17:40:43 UTC) #2
Tom Sepez
LGTM. It's in a CPP file, so I'm not worried about its scope, and ideally, ...
4 years, 7 months ago (2016-05-05 17:44:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951383002/1
4 years, 7 months ago (2016-05-05 17:45:44 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 17:57:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/1f00dbf0203bdd6b4100457301fef1216546...

Powered by Google App Engine
This is Rietveld 408576698