Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1951363003: Report when members indirectly inherited through a mixin are not implemented (issue 26411) (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report when members indirectly inherited through a mixin are not implemented (issue 26411) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8c244f03adcd46ed2e9aaae8643f6cea7eb3a301

Patch Set 1 #

Patch Set 2 : Fixed test failures #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -41 lines) Patch
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 1 4 chunks +16 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 2 chunks +50 lines, -0 lines 4 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +0 lines, -17 lines 0 comments Download
M tests/language/mixin_of_mixin_test.dart View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-05 21:58:46 UTC) #2
Brian Wilkerson
Hold off on reviewing this; there are test failures I need to investigate first.
4 years, 7 months ago (2016-05-05 22:12:16 UTC) #3
Brian Wilkerson
PTAL. The tests pass now.
4 years, 7 months ago (2016-05-06 17:48:05 UTC) #4
scheglov
LGTM https://codereview.chromium.org/1951363003/diff/20001/pkg/analyzer/test/generated/inheritance_manager_test.dart File pkg/analyzer/test/generated/inheritance_manager_test.dart (right): https://codereview.chromium.org/1951363003/diff/20001/pkg/analyzer/test/generated/inheritance_manager_test.dart#newcode301 pkg/analyzer/test/generated/inheritance_manager_test.dart:301: expect(mapC.length, _numOfMembersInObject + 2); expect(mapC, hasLength(_numOfMembersInObject + 2)); ...
4 years, 7 months ago (2016-05-06 17:59:47 UTC) #5
Brian Wilkerson
https://codereview.chromium.org/1951363003/diff/20001/pkg/analyzer/test/generated/inheritance_manager_test.dart File pkg/analyzer/test/generated/inheritance_manager_test.dart (right): https://codereview.chromium.org/1951363003/diff/20001/pkg/analyzer/test/generated/inheritance_manager_test.dart#newcode301 pkg/analyzer/test/generated/inheritance_manager_test.dart:301: expect(mapC.length, _numOfMembersInObject + 2); Done https://codereview.chromium.org/1951363003/diff/20001/pkg/analyzer/test/generated/inheritance_manager_test.dart#newcode916 pkg/analyzer/test/generated/inheritance_manager_test.dart:916: expect(mapC.length, _numOfMembersInObject); ...
4 years, 7 months ago (2016-05-06 18:25:37 UTC) #6
Brian Wilkerson
4 years, 7 months ago (2016-05-06 18:29:49 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8c244f03adcd46ed2e9aaae8643f6cea7eb3a301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698