[MD Extensions]: Fix sidebar icons

[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=529395
BUG=609424
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9ad53bd9dcd6407673274e99e04bb92dee46942b
Cr-Commit-Position: refs/heads/master@{#391905}

[Devlin, 2016-05-05 16:53:00]

Description was changed from

==========
[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=609424
==========

to

==========
[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=609424
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2016-05-05 16:59:53]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-05-05 17:00:17]

rdevlin.cronin@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Devlin, 2016-05-05 17:00:18]

+a test

[Devlin, 2016-05-05 17:04:06]

Description was changed from

==========
[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=609424
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=529395
BUG=609424
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-05 17:06:28]

lgtm but see hint for suggested follow-up CL :-)

https://codereview.chromium.org/1951323002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/extensions/extension_test_util.js (right):

https://codereview.chromium.org/1951323002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_test_util.js:128: * Tests that any
iron-element child of an HTML element has a corresponding
iron-icon

https://codereview.chromium.org/1951323002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_test_util.js:133:
e.querySelectorAll('* /deep/ iron-icon').forEach(function(icon) {
out of curiosity, what happens when e == document.body and you call this from
polymer_browser_test_base.js (hint hint)?

[Devlin, 2016-05-05 20:28:27]

Patchset #2 (id:40001) has been deleted

[Devlin, 2016-05-05 20:28:32]

https://codereview.chromium.org/1951323002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/extensions/extension_test_util.js (right):

https://codereview.chromium.org/1951323002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_test_util.js:128: * Tests that any
iron-element child of an HTML element has a corresponding
On 2016/05/05 17:06:27, michaelpg wrote:
> iron-icon

whoops, done.

https://codereview.chromium.org/1951323002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_test_util.js:133:
e.querySelectorAll('* /deep/ iron-icon').forEach(function(icon) {
On 2016/05/05 17:06:27, michaelpg wrote:
> out of curiosity, what happens when e == document.body and you call this from
> polymer_browser_test_base.js (hint hint)?

Discussed offline, will experiment in a followup cl

[Devlin, 2016-05-05 20:28:36]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-05-05 20:28:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1951323002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-05 20:29:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951323002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951323002/60001

[commit-bot: I haz the power, 2016-05-05 21:34:27]

Description was changed from

==========
[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=529395
BUG=609424
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=529395
BUG=609424
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-05 21:34:28]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-05 21:36:54]

Description was changed from

==========
[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=529395
BUG=609424
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions]: Fix sidebar icons

sidebar.html relied on iron-icons but didn't include them. Add the
missing import and a general regression test.

BUG=529395
BUG=609424
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9ad53bd9dcd6407673274e99e04bb92dee46942b
Cr-Commit-Position: refs/heads/master@{#391905}
==========

[commit-bot: I haz the power, 2016-05-05 21:36:55]

Patchset 2 (id:??) landed as
https://crrev.com/9ad53bd9dcd6407673274e99e04bb92dee46942b
Cr-Commit-Position: refs/heads/master@{#391905}