Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2877)

Unified Diff: chrome/browser/about_flags.cc

Issue 1951273003: Add an about flag to toggle the visibility of "All bookmarks" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 2485bc60948dc16cf5f10b26c4b573ddd93666ea..bb238207bffafbb3d8c980435dabad09599f2c40 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -514,6 +514,14 @@ const FeatureEntry::Choice kHerbPrototypeChoices[] = {
{IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_ELDERBERRY,
switches::kTabManagementExperimentTypeElderberry, ""},
};
+
+const FeatureEntry::Choice kEnableAllBookmarksViewChoices[] = {
+ { IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_CHOICE_DEFAULT, "", ""},
+ { IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_CHOICE_ENABLED,
+ switches::kEnableAllBookmarksView, "true" },
+ { IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_CHOICE_DISABLED,
+ switches::kEnableAllBookmarksView, "false" },
+};
#endif // defined(OS_ANDROID)
const FeatureEntry::Choice kEnableUseZoomForDSFChoices[] = {
@@ -1140,6 +1148,9 @@ const FeatureEntry kFeatureEntries[] = {
SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)},
#endif
#if defined(OS_ANDROID)
+ {"enable-all-bookmarks-view", IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_NAME,
+ IDS_FLAGS_SHOW_ALL_BOOKMARKS_VIEW_DESCRIPTION, kOsAndroid,
+ MULTI_VALUE_TYPE(kEnableAllBookmarksViewChoices)},
{"enable-accessibility-tab-switcher",
IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME,
IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_DESCRIPTION, kOsAndroid,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698