chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java - Issue 1951273003: Add an about flag to toggle the visibility of "All bookmarks"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java

Issue 1951273003: Add an about flag to toggle the visibility of "All bookmarks" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java

index b53aedd57fc5da084068a1e495d15432bacb99b6..cff10628be6d1c51beb8b329232ccebf55d97759 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java

@@ -253,10 +253,6 @@ public class BookmarkManager implements BookmarkDelegate {

* navigation.

private void setState(BookmarkUIState state) {

- if (!state.isValid(mBookmarkModel)) {

- state = BookmarkUIState.createAllBookmarksState(mBookmarkModel);

- }

if (!mStateStack.isEmpty() && mStateStack.peek().equals(state)) return;

// The loading state is not persisted in history stack and once we have a valid state it