Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java

Issue 1951273003: Add an about flag to toggle the visibility of "All bookmarks" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java
index ec8851c19b9ae701bfe25f90413af925441e513d..ae7e3112d5891e9471db34353f95fbd24f5081ee 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java
@@ -62,7 +62,11 @@ class BookmarkUIState {
state.mUrl = uri.toString();
if (state.mUrl.equals(UrlConstants.BOOKMARKS_URL)) {
- state.mState = STATE_ALL_BOOKMARKS;
+ if (BookmarkUtils.isAllBookmarksViewEnabled()) {
+ state.mState = STATE_ALL_BOOKMARKS;
+ } else {
+ return createFolderState(bookmarkModel.getDefaultFolder(), bookmarkModel);
+ }
} else if (state.mUrl.startsWith(UrlConstants.BOOKMARKS_FOLDER_URL)) {
String path = uri.getLastPathSegment();
if (!path.isEmpty()) {
@@ -72,8 +76,7 @@ class BookmarkUIState {
}
if (!state.isValid(bookmarkModel)) {
- state.mState = STATE_ALL_BOOKMARKS;
- state.mUrl = UrlConstants.BOOKMARKS_URL;
+ return createAllBookmarksState(bookmarkModel);
gone 2016/05/05 21:50:14 Why does this differ from the one above? Should t
Ian Wen 2016/05/05 23:27:07 Will talk offline to explain this.
}
return state;

Powered by Google App Engine
This is Rietveld 408576698