Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1951273003: Add an about flag to toggle the visibility of "All bookmarks" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 switches::kTabManagementExperimentTypeAnise, ""}, 507 switches::kTabManagementExperimentTypeAnise, ""},
508 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_BASIL, 508 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_BASIL,
509 switches::kTabManagementExperimentTypeBasil, ""}, 509 switches::kTabManagementExperimentTypeBasil, ""},
510 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_CHIVE, 510 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_CHIVE,
511 switches::kTabManagementExperimentTypeChive, ""}, 511 switches::kTabManagementExperimentTypeChive, ""},
512 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_DILL, 512 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_DILL,
513 switches::kTabManagementExperimentTypeDill, ""}, 513 switches::kTabManagementExperimentTypeDill, ""},
514 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_ELDERBERRY, 514 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_ELDERBERRY,
515 switches::kTabManagementExperimentTypeElderberry, ""}, 515 switches::kTabManagementExperimentTypeElderberry, ""},
516 }; 516 };
517
518 const FeatureEntry::Choice kEnableAllBookmarksViewChoices[] = {
519 { IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_CHOICE_DEFAULT, "", ""},
520 { IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_CHOICE_ENABLED,
521 switches::kEnableAllBookmarksView, "true" },
522 { IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_CHOICE_DISABLED,
523 switches::kEnableAllBookmarksView, "false" },
524 };
517 #endif // defined(OS_ANDROID) 525 #endif // defined(OS_ANDROID)
518 526
519 const FeatureEntry::Choice kEnableUseZoomForDSFChoices[] = { 527 const FeatureEntry::Choice kEnableUseZoomForDSFChoices[] = {
520 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_DEFAULT, "", ""}, 528 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_DEFAULT, "", ""},
521 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_ENABLED, 529 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_ENABLED,
522 switches::kEnableUseZoomForDSF, "true" }, 530 switches::kEnableUseZoomForDSF, "true" },
523 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_DISABLED, 531 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_DISABLED,
524 switches::kEnableUseZoomForDSF, "false" }, 532 switches::kEnableUseZoomForDSF, "false" },
525 }; 533 };
526 534
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
1133 IDS_FLAGS_GOOGLE_PROFILE_INFO_DESCRIPTION, kOsMac | kOsWin | kOsLinux, 1141 IDS_FLAGS_GOOGLE_PROFILE_INFO_DESCRIPTION, kOsMac | kOsWin | kOsLinux,
1134 SINGLE_VALUE_TYPE(switches::kGoogleProfileInfo)}, 1142 SINGLE_VALUE_TYPE(switches::kGoogleProfileInfo)},
1135 #if defined(ENABLE_APP_LIST) 1143 #if defined(ENABLE_APP_LIST)
1136 {"reset-app-list-install-state", 1144 {"reset-app-list-install-state",
1137 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_NAME, 1145 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_NAME,
1138 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_DESCRIPTION, 1146 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_DESCRIPTION,
1139 kOsMac | kOsWin | kOsLinux, 1147 kOsMac | kOsWin | kOsLinux,
1140 SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)}, 1148 SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)},
1141 #endif 1149 #endif
1142 #if defined(OS_ANDROID) 1150 #if defined(OS_ANDROID)
1151 {"enable-all-bookmarks-view", IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_NAME,
1152 IDS_FLAGS_SHOW_ALL_BOOKMARKS_VIEW_DESCRIPTION, kOsAndroid,
1153 MULTI_VALUE_TYPE(kEnableAllBookmarksViewChoices)},
1143 {"enable-accessibility-tab-switcher", 1154 {"enable-accessibility-tab-switcher",
1144 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME, 1155 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME,
1145 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_DESCRIPTION, kOsAndroid, 1156 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_DESCRIPTION, kOsAndroid,
1146 SINGLE_VALUE_TYPE(switches::kEnableAccessibilityTabSwitcher)}, 1157 SINGLE_VALUE_TYPE(switches::kEnableAccessibilityTabSwitcher)},
1147 {"enable-physical-web", IDS_FLAGS_ENABLE_PHYSICAL_WEB_NAME, 1158 {"enable-physical-web", IDS_FLAGS_ENABLE_PHYSICAL_WEB_NAME,
1148 IDS_FLAGS_ENABLE_PHYSICAL_WEB_DESCRIPTION, kOsAndroid, 1159 IDS_FLAGS_ENABLE_PHYSICAL_WEB_DESCRIPTION, kOsAndroid,
1149 FEATURE_VALUE_TYPE(chrome::android::kPhysicalWebFeature)}, 1160 FEATURE_VALUE_TYPE(chrome::android::kPhysicalWebFeature)},
1150 #endif 1161 #endif
1151 {"enable-zero-copy", IDS_FLAGS_ZERO_COPY_NAME, 1162 {"enable-zero-copy", IDS_FLAGS_ZERO_COPY_NAME,
1152 IDS_FLAGS_ZERO_COPY_DESCRIPTION, kOsAll, 1163 IDS_FLAGS_ZERO_COPY_DESCRIPTION, kOsAll,
(...skipping 877 matching lines...) Expand 10 before | Expand all | Expand 10 after
2030 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2041 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2031 2042
2032 const FeatureEntry* GetFeatureEntries(size_t* count) { 2043 const FeatureEntry* GetFeatureEntries(size_t* count) {
2033 *count = arraysize(kFeatureEntries); 2044 *count = arraysize(kFeatureEntries);
2034 return kFeatureEntries; 2045 return kFeatureEntries;
2035 } 2046 }
2036 2047
2037 } // namespace testing 2048 } // namespace testing
2038 2049
2039 } // namespace about_flags 2050 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698