Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1951273003: Add an about flag to toggle the visibility of "All bookmarks" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1122 matching lines...) Expand 10 before | Expand all | Expand 10 after
1133 IDS_FLAGS_GOOGLE_PROFILE_INFO_DESCRIPTION, kOsMac | kOsWin | kOsLinux, 1133 IDS_FLAGS_GOOGLE_PROFILE_INFO_DESCRIPTION, kOsMac | kOsWin | kOsLinux,
1134 SINGLE_VALUE_TYPE(switches::kGoogleProfileInfo)}, 1134 SINGLE_VALUE_TYPE(switches::kGoogleProfileInfo)},
1135 #if defined(ENABLE_APP_LIST) 1135 #if defined(ENABLE_APP_LIST)
1136 {"reset-app-list-install-state", 1136 {"reset-app-list-install-state",
1137 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_NAME, 1137 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_NAME,
1138 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_DESCRIPTION, 1138 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_DESCRIPTION,
1139 kOsMac | kOsWin | kOsLinux, 1139 kOsMac | kOsWin | kOsLinux,
1140 SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)}, 1140 SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)},
1141 #endif 1141 #endif
1142 #if defined(OS_ANDROID) 1142 #if defined(OS_ANDROID)
1143 {"enable-all-bookmarks-view", IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_NAME,
gone 2016/05/05 21:50:14 Look up FeatureEntry and how that works instead of
Ian Wen 2016/05/05 23:27:08 Done.
1144 IDS_FLAGS_SHOW_ALL_BOOKMARKS_VIEW_DESCRIPTION, kOsAndroid,
1145 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAllBookmarksView,
1146 switches::kDisableAllBookmarksView)},
1143 {"enable-accessibility-tab-switcher", 1147 {"enable-accessibility-tab-switcher",
1144 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME, 1148 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME,
1145 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_DESCRIPTION, kOsAndroid, 1149 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_DESCRIPTION, kOsAndroid,
1146 SINGLE_VALUE_TYPE(switches::kEnableAccessibilityTabSwitcher)}, 1150 SINGLE_VALUE_TYPE(switches::kEnableAccessibilityTabSwitcher)},
1147 {"enable-physical-web", IDS_FLAGS_ENABLE_PHYSICAL_WEB_NAME, 1151 {"enable-physical-web", IDS_FLAGS_ENABLE_PHYSICAL_WEB_NAME,
1148 IDS_FLAGS_ENABLE_PHYSICAL_WEB_DESCRIPTION, kOsAndroid, 1152 IDS_FLAGS_ENABLE_PHYSICAL_WEB_DESCRIPTION, kOsAndroid,
1149 FEATURE_VALUE_TYPE(chrome::android::kPhysicalWebFeature)}, 1153 FEATURE_VALUE_TYPE(chrome::android::kPhysicalWebFeature)},
1150 #endif 1154 #endif
1151 {"enable-zero-copy", IDS_FLAGS_ZERO_COPY_NAME, 1155 {"enable-zero-copy", IDS_FLAGS_ZERO_COPY_NAME,
1152 IDS_FLAGS_ZERO_COPY_DESCRIPTION, kOsAll, 1156 IDS_FLAGS_ZERO_COPY_DESCRIPTION, kOsAll,
(...skipping 871 matching lines...) Expand 10 before | Expand all | Expand 10 after
2024 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2028 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2025 2029
2026 const FeatureEntry* GetFeatureEntries(size_t* count) { 2030 const FeatureEntry* GetFeatureEntries(size_t* count) {
2027 *count = arraysize(kFeatureEntries); 2031 *count = arraysize(kFeatureEntries);
2028 return kFeatureEntries; 2032 return kFeatureEntries;
2029 } 2033 }
2030 2034
2031 } // namespace testing 2035 } // namespace testing
2032 2036
2033 } // namespace about_flags 2037 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698