Issue 195123005: Revert "Enable Object.observe by default"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195123005: Revert "Enable Object.observe by default" (Closed)

Created:
6 years, 9 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 9 months ago

Reviewers:
rafaelw, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Enable Object.observe by default" This reverts commit r19734 for breeaking ChromiumOS browser tests. 'OpenSpecialTypes/FileManagerBrowserTest.Test/3' started to time out, bisecting the roll led to this change. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22224 TBR=rafaelw@chromium.org,rossberg@chromium.org BUG=v8:2409 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=19816

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+214 lines, -1998 lines)			Patch
M	src/accessors.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/bootstrapper.cc	View	3 chunks	+9 lines, -6 lines	0 comments	Download
M	src/flag-definitions.h	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/object-observe.js	View	7 chunks	+51 lines, -97 lines	0 comments	Download
M	src/objects.cc	View	10 chunks	+15 lines, -10 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	2 chunks	+10 lines, -13 lines	0 comments	Download
M	test/cctest/test-microtask-delivery.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-object-observe.cc	View	25 chunks	+116 lines, -78 lines	0 comments	Download
M	test/mjsunit/debug-script.js	View	1 chunk	+1 line, -1 line	0 comments	Download
D	test/mjsunit/es7/object-observe.js	View	1 chunk	+0 lines, -1789 lines	0 comments	Download
A +	test/mjsunit/harmony/object-observe.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Lomov (no reviews)

Committed patchset #1 manually as r19816 (presubmit successful).

6 years, 9 months ago (2014-03-11 18:15:58 UTC) #1

Message was sent while issue was closed.

lgtm

lgtm