Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 195123002: Harmony: move math features to es-staging. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Harmony: move math features to es-staging. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19886

Patch Set 1 #

Patch Set 2 : done #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-9 lines, -610 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 1 comment Download
A + test/mjsunit/es6/math-cbrt.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-clz32.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-expm1.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-fround.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-hyperbolic.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-hypot.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-log1p.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-log2-log10.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-sign.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/es6/math-trunc.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D test/mjsunit/harmony/math-cbrt.js View 1 1 chunk +0 lines, -27 lines 0 comments Download
D test/mjsunit/harmony/math-clz32.js View 1 1 chunk +0 lines, -36 lines 0 comments Download
D test/mjsunit/harmony/math-expm1.js View 1 1 chunk +0 lines, -38 lines 0 comments Download
D test/mjsunit/harmony/math-fround.js View 1 1 chunk +0 lines, -99 lines 0 comments Download
D test/mjsunit/harmony/math-hyperbolic.js View 1 1 chunk +0 lines, -138 lines 0 comments Download
D test/mjsunit/harmony/math-hypot.js View 1 1 chunk +0 lines, -94 lines 0 comments Download
D test/mjsunit/harmony/math-log1p.js View 1 1 chunk +0 lines, -41 lines 0 comments Download
D test/mjsunit/harmony/math-log2-log10.js View 1 1 chunk +0 lines, -47 lines 0 comments Download
D test/mjsunit/harmony/math-sign.js View 1 1 chunk +0 lines, -48 lines 0 comments Download
D test/mjsunit/harmony/math-trunc.js View 1 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 9 months ago (2014-03-11 13:58:06 UTC) #1
Yang
On 2014/03/11 13:58:06, Yang wrote: Also moved the files to es6 as suggested.
6 years, 9 months ago (2014-03-11 14:20:05 UTC) #2
rossberg
lgtm https://codereview.chromium.org/195123002/diff/20001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/195123002/diff/20001/src/flag-definitions.h#newcode190 src/flag-definitions.h:190: DEFINE_implication(harmony, es_staging) Nit: just to group this a ...
6 years, 9 months ago (2014-03-11 14:36:18 UTC) #3
Yang
6 years, 9 months ago (2014-03-13 09:52:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r19886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698