ui/views/controls/menu/menu_runner_cocoa_unittest.mm - Issue 1951223002: MacViews: Fix failing Menu Runner Cocoa Tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner_cocoa_unittest.mm

Issue 1951223002: MacViews: Fix failing Menu Runner Cocoa Tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nit. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_runner_cocoa_unittest.mm

diff --git a/ui/views/controls/menu/menu_runner_cocoa_unittest.mm b/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

index ee86b98275691c9349bcf84962c0bf5838d70af2..4ce56dd7a4c5aa6d5f11323b466d2c335fe1576a 100644

--- a/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

+++ b/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

@@ -129,7 +129,10 @@ class MenuRunnerCocoaTest : public ViewsTestBase {

void MenuCancelCallback() {

runner_->Cancel();

- EXPECT_FALSE(runner_->IsRunning());

+ // For a syncronous menu, MenuRunner::IsRunning() should return true

+ // immediately after MenuRunner::Cancel() since the menu message loop has

+ // not yet terminated. It has only been marked for termination.

+ EXPECT_TRUE(runner_->IsRunning());

}

void MenuDeleteCallback() {

« no previous file with comments | « chrome/browser/ui/views/menu_test_base.h ('k') | no next file » | no next file with comments »