Avoid incrementing an invalid iterator in the utility process client.

Avoid incrementing an invalid iterator in the utility process client.

BUG=597124
Committed: https://crrev.com/b84adb70aa05a1f9af36f6eca29cf3cf760c02bf
Cr-Commit-Position: refs/heads/master@{#392496}

[Anand Mistry (off Chromium), 2016-05-05 07:22:49]

amistry@chromium.org changed reviewers:
+ jochen@chromium.org

[Anand Mistry (off Chromium), 2016-05-05 07:22:50]

Sorry. This might be the stupidest change you see all week.

[jochen (gone - plz use gerrit), 2016-05-06 10:32:30]

https://codereview.chromium.org/1951213002/diff/1/chrome/utility/chrome_conte...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/1951213002/diff/1/chrome/utility/chrome_conte...
chrome/utility/chrome_content_utility_client.cc:178: for (Handlers::iterator it
= handlers_.begin();
why not:

if (handled) return true;

for (auto& handler : handlers_)
  if (handler->OnMessageReceived(message)) return true;

return false;

[Anand Mistry (off Chromium), 2016-05-09 02:32:14]

https://codereview.chromium.org/1951213002/diff/1/chrome/utility/chrome_conte...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/1951213002/diff/1/chrome/utility/chrome_conte...
chrome/utility/chrome_content_utility_client.cc:178: for (Handlers::iterator it
= handlers_.begin();
On 2016/05/06 10:32:30, jochen wrote:
> why not:
> 
> if (handled) return true;
> 
> for (auto& handler : handlers_)
>   if (handler->OnMessageReceived(message)) return true;
> 
> return false;

I was just trying to minimise the change. I've changed the logic, but kept the
comment (mostly).

[jochen (gone - plz use gerrit), 2016-05-09 15:26:02]

lgtm

[Anand Mistry (off Chromium), 2016-05-10 00:17:23]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2016-05-10 00:17:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951213002/20001

[commit-bot: I haz the power, 2016-05-10 00:46:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 00:47:38]

Description was changed from

==========
Avoid incrementing an invalid iterator in the utility process client.

BUG=597124
==========

to

==========
Avoid incrementing an invalid iterator in the utility process client.

BUG=597124

Committed: https://crrev.com/b84adb70aa05a1f9af36f6eca29cf3cf760c02bf
Cr-Commit-Position: refs/heads/master@{#392496}
==========

[commit-bot: I haz the power, 2016-05-10 00:47:39]

Patchset 2 (id:??) landed as
https://crrev.com/b84adb70aa05a1f9af36f6eca29cf3cf760c02bf
Cr-Commit-Position: refs/heads/master@{#392496}