Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1951213002: Avoid incrementing an invalid iterator in the utility process client. (Closed)

Created:
4 years, 7 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid incrementing an invalid iterator in the utility process client. BUG=597124 Committed: https://crrev.com/b84adb70aa05a1f9af36f6eca29cf3cf760c02bf Cr-Commit-Position: refs/heads/master@{#392496}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/utility/chrome_content_utility_client.cc View 1 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Anand Mistry (off Chromium)
Sorry. This might be the stupidest change you see all week.
4 years, 7 months ago (2016-05-05 07:22:50 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1951213002/diff/1/chrome/utility/chrome_content_utility_client.cc File chrome/utility/chrome_content_utility_client.cc (right): https://codereview.chromium.org/1951213002/diff/1/chrome/utility/chrome_content_utility_client.cc#newcode178 chrome/utility/chrome_content_utility_client.cc:178: for (Handlers::iterator it = handlers_.begin(); why not: if (handled) ...
4 years, 7 months ago (2016-05-06 10:32:30 UTC) #3
Anand Mistry (off Chromium)
https://codereview.chromium.org/1951213002/diff/1/chrome/utility/chrome_content_utility_client.cc File chrome/utility/chrome_content_utility_client.cc (right): https://codereview.chromium.org/1951213002/diff/1/chrome/utility/chrome_content_utility_client.cc#newcode178 chrome/utility/chrome_content_utility_client.cc:178: for (Handlers::iterator it = handlers_.begin(); On 2016/05/06 10:32:30, jochen ...
4 years, 7 months ago (2016-05-09 02:32:14 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-09 15:26:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951213002/20001
4 years, 7 months ago (2016-05-10 00:17:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 00:46:24 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 00:47:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b84adb70aa05a1f9af36f6eca29cf3cf760c02bf
Cr-Commit-Position: refs/heads/master@{#392496}

Powered by Google App Engine
This is Rietveld 408576698