Implement VariableMirror creation with non-API code. To break circular initialization, have them fi…

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 // These values are allowed to be passed directly over the wire.
 bool _isSimpleValue(var value) {
   return (value == null || value is num || value is String || value is bool);
 }
@@ skipping 1019 matching lines @@
     return owner is LibraryMirror;
   }
 
   SourceLocation get location {
     throw new UnimplementedError(
         'VariableMirror.location is not implemented');
   }
 
   var _type;
   TypeMirror get type {
+    if (_type == null) {
+       _type = _VariableMirror_type(_reflectee);
+    }
     if (_type is! Mirror) {
       _type = _type.resolve(mirrors);
     }
     return _type;
   }
 
   final bool isStatic;
   final bool isFinal;
 
   String toString() => "VariableMirror on '${_n(simpleName)}'";
+
+  static _VariableMirror_type(reflectee)
+      native "VariableMirror_type";
 }
 
 class _LocalParameterMirrorImpl extends _LocalVariableMirrorImpl
     implements ParameterMirror {
   _LocalParameterMirrorImpl(type, this.isOptional)
       : super(null, '<TODO:unnamed>', null, type, false, false) {}
 
   final bool isOptional;
 
   String get defaultValue {
@@ skipping 29 matching lines @@
   SourceLocation get location {
     throw new UnimplementedError(
         'TypeMirror.location is not implemented');
   }
 
   Symbol get qualifiedName {
     return simpleName;
   }
 
   String toString() => "TypeMirror on '${_n(simpleName)}'";
+
+  operator ==(other) {

[rmacnak, 2013/07/20 00:46:52]

Allow tests to pass which previously relied on the mirrors for void and dynamic
being canonical. They will be canonical again once they are in the object store.

[siva, 2013/07/22 05:25:32]

Please add an issue to track this temporary workaround and add a TODO(#number)
here to get rid of this code once void and dynamic types are created in the VM
isolate.

On 2013/07/20 00:46:52, Ryan Macnak wrote:

[rmacnak, 2013/07/22 19:05:09]

Done.

+    if (other is! _SpecialTypeMirrorImpl) {
+      return false;
+    }
+    return this.simpleName == other.simpleName;
+  }
 }
 
 class _Mirrors {
   // Does a port refer to our local isolate?
   static bool isLocalPort(SendPort port) native 'Mirrors_isLocalPort';
 
   static MirrorSystem _currentMirrorSystem = null;
 
   // Creates a new local MirrorSystem.
   static MirrorSystem makeLocalMirrorSystem()
@@ skipping 38 matching lines @@
   static Expando<ClassMirror> _classMirrorCache = new Expando("ClassMirror");
   static ClassMirror reflectClass(Type key) {
     var classMirror = _classMirrorCache[key];
     if (classMirror == null) {
       classMirror = makeLocalClassMirror(key);
       _classMirrorCache[key] = classMirror;
     }
     return classMirror;
   }
 }