Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 1951153002: Remove AddSearchProvider (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AddSearchProvider BUG=542487 TBR=jwd@chromium.org Committed: https://crrev.com/7bfdaf717592bb62de6ef2dd1a518be6e8353e03 Cr-Commit-Position: refs/heads/master@{#392688}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : fix unit test #

Total comments: 18

Patch Set 4 : pkasting review, remove .xib #

Patch Set 5 : add test comment #

Total comments: 1

Patch Set 6 : obsolescence date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -1510 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/app/nibs/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D chrome/app/nibs/EditSearchEngine.xib View 1 2 3 1 chunk +0 lines, -192 lines 0 comments Download
D chrome/app/theme/default_100_percent/common/input_good.png View 1 2 3 Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/input_good.png View 1 2 3 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 2 3 4 11 chunks +70 lines, -143 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.h View 1 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.mm View 1 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm View 1 1 chunk +0 lines, -259 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/search_engines/edit_search_engine_controller.h View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.h View 3 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 3 chunks +6 lines, -35 lines 0 comments Download
D chrome/browser/ui/search_engines/search_engine_tab_helper_delegate.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/ui/search_engines/search_engine_tab_helper_delegate.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/ui/views/edit_search_engine_dialog.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 chunk +0 lines, -268 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome_nibs.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_nibs.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/external_extension.cc View 4 chunks +0 lines, -38 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/search_engines/template_url_fetcher.h View 1 2 3 3 chunks +10 lines, -19 lines 0 comments Download
M components/search_engines/template_url_fetcher.cc View 1 2 3 8 chunks +27 lines, -67 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 28 (12 generated)
Evan Stade
4 years, 7 months ago (2016-05-05 21:30:25 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/1951153002/diff/40001/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (left): https://codereview.chromium.org/1951153002/diff/40001/chrome/app/theme/theme_resources.grd#oldcode392 chrome/app/theme/theme_resources.grd:392: <structure type="chrome_scaled_image" name="IDR_INPUT_GOOD" file="common/input_good.png" /> Remove this .png ...
4 years, 7 months ago (2016-05-09 22:24:00 UTC) #3
Evan Stade
+jwd for histograms.xml +groby for *nibs* https://codereview.chromium.org/1951153002/diff/40001/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (left): https://codereview.chromium.org/1951153002/diff/40001/chrome/app/theme/theme_resources.grd#oldcode392 chrome/app/theme/theme_resources.grd:392: <structure type="chrome_scaled_image" name="IDR_INPUT_GOOD" ...
4 years, 7 months ago (2016-05-09 22:54:53 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951153002/60001
4 years, 7 months ago (2016-05-09 22:55:42 UTC) #7
Peter Kasting
https://codereview.chromium.org/1951153002/diff/40001/chrome/browser/search_engines/template_url_fetcher_unittest.cc File chrome/browser/search_engines/template_url_fetcher_unittest.cc (right): https://codereview.chromium.org/1951153002/diff/40001/chrome/browser/search_engines/template_url_fetcher_unittest.cc#newcode221 chrome/browser/search_engines/template_url_fetcher_unittest.cc:221: EXPECT_EQ(0, requests_completed()); On 2016/05/09 22:54:53, Evan Stade wrote: > ...
4 years, 7 months ago (2016-05-09 22:57:32 UTC) #8
groby-ooo-7-16
c/b/ui/cocoa + xib changes RS LGTM
4 years, 7 months ago (2016-05-09 23:27:24 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 23:51:08 UTC) #11
Evan Stade
moving jwd to TBR (for marking histogram obsolete)
4 years, 7 months ago (2016-05-10 16:49:48 UTC) #13
Evan Stade
https://codereview.chromium.org/1951153002/diff/40001/chrome/browser/search_engines/template_url_fetcher_unittest.cc File chrome/browser/search_engines/template_url_fetcher_unittest.cc (right): https://codereview.chromium.org/1951153002/diff/40001/chrome/browser/search_engines/template_url_fetcher_unittest.cc#newcode221 chrome/browser/search_engines/template_url_fetcher_unittest.cc:221: EXPECT_EQ(0, requests_completed()); On 2016/05/09 22:57:32, Peter Kasting wrote: > ...
4 years, 7 months ago (2016-05-10 16:51:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951153002/80001
4 years, 7 months ago (2016-05-10 16:52:28 UTC) #17
jwd
https://codereview.chromium.org/1951153002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1951153002/diff/80001/tools/metrics/histograms/histograms.xml#newcode47389 tools/metrics/histograms/histograms.xml:47389: + AddSearchProvider was removed. Can you add the mm/yyyy ...
4 years, 7 months ago (2016-05-10 18:14:08 UTC) #18
jwd
lgtm
4 years, 7 months ago (2016-05-10 18:14:25 UTC) #19
Evan Stade
added date
4 years, 7 months ago (2016-05-10 18:17:35 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951153002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951153002/100001
4 years, 7 months ago (2016-05-10 18:18:57 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-10 19:45:25 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 19:47:35 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7bfdaf717592bb62de6ef2dd1a518be6e8353e03
Cr-Commit-Position: refs/heads/master@{#392688}

Powered by Google App Engine
This is Rietveld 408576698