[Mac][Material Design] Get Omnibox table width from dropdown window.

[Mac][Material Design] Get Omnibox table width from dropdown window.

Under Material Design the suggestion table is the width of the
Omnibox window. OmniboxPopupViewMac::PositionPopup() took this width
from -[BrowserWindowController omniboxPopupAnchorRect], which
returns the empty rect in the unit test test harness. This resulted
in a zero-width table that tripped a DCHECK when called from
OmniboxPopupViewMacTest.UpdatePopupAppearance.

With this change the Omnibox grabs the window width direclty from the
Omnibox textfield's window, which is available under normal usage
and in the test harness.

R=avi@chromium.org
BUG=609312
Committed: https://crrev.com/d60d2a2181c8d3a635eb17d784dfd3402b8c8c92
Cr-Commit-Position: refs/heads/master@{#391860}

[shrike, 2016-05-04 23:02:11]

Description was changed from

==========
[Mac][Material Design] Get Omnibox table width from dropdown window.

Under Material Design the results table is the width of the Omnibox
window. OmniboxPopupViewMac::PositionPopup() took this width from
-[BrowserWindowController omniboxPopupAnchorRect], which returns the
empty rect in the unit test test harness. This change computes the
window width by taking it direclty from the omnibox textfield's window,
which is available under normal usage and in the test harness.

BUG=609312
==========

to

==========
[Mac][Material Design] Get Omnibox table width from dropdown window.

Under Material Design the suggestion table is the width of the
Omnibox window. OmniboxPopupViewMac::PositionPopup() took this width
from -[BrowserWindowController omniboxPopupAnchorRect], which
returns the empty rect in the unit test test harness. This resulted
in a zero-width table that tripped a DCHECK when called from
OmniboxPopupViewMacTest.UpdatePopupAppearance.

With this change the Omnibox grabs the window width direclty from the
Omnibox textfield's window, which is available under normal usage
and in the test harness.

R=avi@chromium.org
BUG=609312
==========

[shrike, 2016-05-04 23:02:11]

shrike@chromium.org changed reviewers:
+ avi@chromium.org

[shrike, 2016-05-04 23:02:20]

PTAL

[Avi (use Gerrit), 2016-05-05 02:02:28]

lgtm

[shrike, 2016-05-05 17:33:46]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-05 17:34:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951143002/1

[commit-bot: I haz the power, 2016-05-05 18:57:56]

Description was changed from

==========
[Mac][Material Design] Get Omnibox table width from dropdown window.

Under Material Design the suggestion table is the width of the
Omnibox window. OmniboxPopupViewMac::PositionPopup() took this width
from -[BrowserWindowController omniboxPopupAnchorRect], which
returns the empty rect in the unit test test harness. This resulted
in a zero-width table that tripped a DCHECK when called from
OmniboxPopupViewMacTest.UpdatePopupAppearance.

With this change the Omnibox grabs the window width direclty from the
Omnibox textfield's window, which is available under normal usage
and in the test harness.

R=avi@chromium.org
BUG=609312
==========

to

==========
[Mac][Material Design] Get Omnibox table width from dropdown window.

Under Material Design the suggestion table is the width of the
Omnibox window. OmniboxPopupViewMac::PositionPopup() took this width
from -[BrowserWindowController omniboxPopupAnchorRect], which
returns the empty rect in the unit test test harness. This resulted
in a zero-width table that tripped a DCHECK when called from
OmniboxPopupViewMacTest.UpdatePopupAppearance.

With this change the Omnibox grabs the window width direclty from the
Omnibox textfield's window, which is available under normal usage
and in the test harness.

R=avi@chromium.org
BUG=609312
==========

[commit-bot: I haz the power, 2016-05-05 18:57:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-05 18:59:20]

Description was changed from

==========
[Mac][Material Design] Get Omnibox table width from dropdown window.

Under Material Design the suggestion table is the width of the
Omnibox window. OmniboxPopupViewMac::PositionPopup() took this width
from -[BrowserWindowController omniboxPopupAnchorRect], which
returns the empty rect in the unit test test harness. This resulted
in a zero-width table that tripped a DCHECK when called from
OmniboxPopupViewMacTest.UpdatePopupAppearance.

With this change the Omnibox grabs the window width direclty from the
Omnibox textfield's window, which is available under normal usage
and in the test harness.

R=avi@chromium.org
BUG=609312
==========

to

==========
[Mac][Material Design] Get Omnibox table width from dropdown window.

Under Material Design the suggestion table is the width of the
Omnibox window. OmniboxPopupViewMac::PositionPopup() took this width
from -[BrowserWindowController omniboxPopupAnchorRect], which
returns the empty rect in the unit test test harness. This resulted
in a zero-width table that tripped a DCHECK when called from
OmniboxPopupViewMacTest.UpdatePopupAppearance.

With this change the Omnibox grabs the window width direclty from the
Omnibox textfield's window, which is available under normal usage
and in the test harness.

R=avi@chromium.org
BUG=609312

Committed: https://crrev.com/d60d2a2181c8d3a635eb17d784dfd3402b8c8c92
Cr-Commit-Position: refs/heads/master@{#391860}
==========

[commit-bot: I haz the power, 2016-05-05 18:59:21]

Patchset 1 (id:??) landed as
https://crrev.com/d60d2a2181c8d3a635eb17d784dfd3402b8c8c92
Cr-Commit-Position: refs/heads/master@{#391860}