Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 1951133002: Use gold and the bundled binutils on x86 by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 import("//build/toolchain/toolchain.gni") 9 import("//build/toolchain/toolchain.gni")
10 10
(...skipping 17 matching lines...) Expand all
28 # 2 : Used during the PGO (optimization) phase. 28 # 2 : Used during the PGO (optimization) phase.
29 # 29 #
30 # TODO(sebmarchand): Add support for the PGU (update) phase. 30 # TODO(sebmarchand): Add support for the PGU (update) phase.
31 chrome_pgo_phase = 0 31 chrome_pgo_phase = 0
32 32
33 # Whether or not the official builds should be build with full WPO. 33 # Whether or not the official builds should be build with full WPO.
34 full_wpo_on_official = false 34 full_wpo_on_official = false
35 } 35 }
36 36
37 declare_args() { 37 declare_args() {
38 # TODO: We should be using 64-bit gold for linking on both 64-bit Linux
39 # and 32-bit linux; 32-bit Gold runs out of address-space on 32-bit builds.
40 # However, something isn't quite working right on the 32-bit builds.
41 use_gold = !use_lld && 38 use_gold = !use_lld &&
42 ((is_linux && (current_cpu == "x64" || current_cpu == "arm")) || 39 ((is_linux && (current_cpu == "x64" || current_cpu == "x86" ||
40 current_cpu == "arm")) ||
43 (is_android && (current_cpu == "x86" || current_cpu == "x64" || 41 (is_android && (current_cpu == "x86" || current_cpu == "x64" ||
44 current_cpu == "arm"))) 42 current_cpu == "arm")))
45 } 43 }
46 44
47 # If it wasn't manually set, set to an appropriate default. 45 # If it wasn't manually set, set to an appropriate default.
48 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") 46 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level")
49 if (symbol_level == -1) { 47 if (symbol_level == -1) {
50 if (is_android && use_order_profiling) { 48 if (is_android && use_order_profiling) {
51 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which 49 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which
52 # causes the linker to produce an invalid ELF. http://crbug.com/574476 50 # causes the linker to produce an invalid ELF. http://crbug.com/574476
(...skipping 12 matching lines...) Expand all
65 symbol_level = 1 63 symbol_level = 1
66 } else { 64 } else {
67 symbol_level = 0 65 symbol_level = 0
68 } 66 }
69 } 67 }
70 68
71 # PGO requires full WPO. 69 # PGO requires full WPO.
72 if (chrome_pgo_phase > 0) { 70 if (chrome_pgo_phase > 0) {
73 full_wpo_on_official = true 71 full_wpo_on_official = true
74 } 72 }
OLDNEW
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698