old -- Fix for 32767 issue

src/effects/SkBlurMaskFilter.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkBlurMaskFilter.h"
 #include "SkBlurMask.h"
@@ skipping 303 matching lines @@
     const SkScalar bottomUnstretched = SkTMax(LL.fY, LR.fY) + SkIntToScalar(2 * margin.fY);
 
     const SkScalar totalSmallHeight = topUnstretched + bottomUnstretched + stretchSize;
     if (totalSmallHeight >= rrect.rect().height()) {
         // There is no valid piece to stretch.
         return kUnimplemented_FilterReturn;
     }
 
     SkRect smallR = SkRect::MakeWH(totalSmallWidth, totalSmallHeight);
 
+    if (smallR.width() * smallR.height() > clipBounds.width() * clipBounds.height()) {
+        // This path creates the nine-patch and then draws it. The fallback
+        // path draws the clipped path, blurs it then blits it. If we are
+        // going to touch more pixels using this path we should probably just
+        // fall back.
+        return kUnimplemented_FilterReturn;
+    }
+
     SkRRect smallRR;
     SkVector radii[4];
     radii[SkRRect::kUpperLeft_Corner] = UL;
     radii[SkRRect::kUpperRight_Corner] = UR;
     radii[SkRRect::kLowerRight_Corner] = LR;
     radii[SkRRect::kLowerLeft_Corner] = LL;
     smallRR.setRectRadii(smallR, radii);
 
     if (!draw_rrect_into_mask(smallRR, &srcM)) {
         return kFalse_FilterReturn;
@@ skipping 110 matching lines @@
     smallR[0].set(rects[0].left(), rects[0].top(), rects[0].right() - dx, rects[0].bottom() - dy);
     if (smallR[0].width() < 2 || smallR[0].height() < 2) {
         return kUnimplemented_FilterReturn;
     }
     if (2 == count) {
         smallR[1].set(rects[1].left(), rects[1].top(),
                       rects[1].right() - dx, rects[1].bottom() - dy);
         SkASSERT(!smallR[1].isEmpty());
     }
 
+#if 0
+    // Both filterRectsToNine and filterRRectToNine share this problem
+    // (potentially trying to allocate too large a nine-patch mask). 
+    // Chromium is currently seeing the filterRRectToNine crash but we have
+    // not yet seen the filterRectsToNine corrolate. Presumably we will have 
+    // to enable this code some day but more testing is required (For example,
+    // since the analytic case is faster then the normal blur should we
+    // actually have a constant multiplier in the following inequality).
+    if (smallR[0].width() * smallR[0].height() >
+        clipBounds.width() * clipBounds.height()) {
+        // This path creates the nine-patch and then draws it. The fallback
+        // path draws the clipped path, blurs it then blits it. If we are
+        // going to touch more pixels using this path we should probably just
+        // fall back.
+        return kUnimplemented_FilterReturn;
+    }
+#endif
+
     if (count > 1 || !c_analyticBlurNinepatch) {
         if (!draw_rects_into_mask(smallR, count, &srcM)) {
             return kFalse_FilterReturn;
         }
 
         SkAutoMaskFreeImage amf(srcM.fImage);
 
         if (!this->filterMask(&patch->fMask, srcM, matrix, &margin)) {
             return kFalse_FilterReturn;
         }
@@ skipping 151 matching lines @@
     } else {
         str->append("None");
     }
     str->append("))");
 }
 #endif
 
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_START(SkBlurMaskFilter)
     SK_DEFINE_FLATTENABLE_REGISTRAR_ENTRY(SkBlurMaskFilterImpl)
 SK_DEFINE_FLATTENABLE_REGISTRAR_GROUP_END