Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1951083002: Add three missing test files to gn builds (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add three missing test files to gn builds BUG=604060 Committed: https://crrev.com/1cbbf55e024f75c92b765ef001691aebfd3234cc Cr-Commit-Position: refs/heads/master@{#391755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/metrics/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_json/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
brucedawson
These files are in gyp builds but not gn builds. PTAL. You were the obvious ...
4 years, 7 months ago (2016-05-04 19:37:12 UTC) #2
Cait (Slow)
lgtm
4 years, 7 months ago (2016-05-04 21:03:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951083002/1
4 years, 7 months ago (2016-05-04 21:20:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/61479)
4 years, 7 months ago (2016-05-04 21:30:12 UTC) #7
brucedawson
On 2016/05/04 21:30:12, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-04 21:45:02 UTC) #8
brucedawson
On 2016/05/04 21:30:12, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-04 21:45:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951083002/1
4 years, 7 months ago (2016-05-04 21:45:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/65271)
4 years, 7 months ago (2016-05-05 00:53:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951083002/1
4 years, 7 months ago (2016-05-05 03:39:24 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 04:39:24 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 04:41:07 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cbbf55e024f75c92b765ef001691aebfd3234cc
Cr-Commit-Position: refs/heads/master@{#391755}

Powered by Google App Engine
This is Rietveld 408576698