third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 1951043002: Don't let PaintInvalidationLocationChange shadow other reasons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1951043002: Don't let PaintInvalidationLocationChange shadow other reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/repaint-subrect-grid-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 12ce17b0c319397192da806f712b687abaec559a..ba4acad492869c8797857c75bf02ce3f29c3ef6a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -394,13 +394,14 @@ void LayoutBoxModelObject::invalidateTreeIfNeeded(const PaintInvalidationState&

return;

LayoutRect previousPaintInvalidationRect = this->previousPaintInvalidationRect();

+ LayoutPoint previousPosition = previousPositionFromPaintInvalidationBacking();

PaintInvalidationReason reason = invalidatePaintIfNeeded(newPaintInvalidationState);

clearPaintInvalidationFlags(newPaintInvalidationState);

if (reason == PaintInvalidationDelayedFull)

paintInvalidationState.pushDelayedPaintInvalidationTarget(*this);

- if (reason == PaintInvalidationLocationChange)

+ if (previousPosition != previousPositionFromPaintInvalidationBacking())

newPaintInvalidationState.setForceSubtreeInvalidationWithinContainer();

// TODO(wangxianzhu): Combine this function into LayoutObject::invalidateTreeIfNeeded() when removing the following workarounds.