Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1951013002: [wasm] Refactor handling of variable info in typing-asm.cc (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
bradnelson, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Refactor handling of variable info in typing-asm.cc R=bradnelson@chromium.org,rossberg@chromium.org BUG= Committed: https://crrev.com/87cbbdfb1e1ac379ffd45fe925938c749cde6ead Cr-Commit-Position: refs/heads/master@{#36052}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -100 lines) Patch
M src/typing-asm.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/typing-asm.cc View 24 chunks +101 lines, -97 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 7 months ago (2016-05-04 14:57:48 UTC) #1
bradnelson
lgtm https://codereview.chromium.org/1951013002/diff/1/src/typing-asm.cc File src/typing-asm.cc (right): https://codereview.chromium.org/1951013002/diff/1/src/typing-asm.cc#newcode687 src/typing-asm.cc:687: if (info == nullptr || info->type == nullptr) ...
4 years, 7 months ago (2016-05-05 04:21:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951013002/1
4 years, 7 months ago (2016-05-05 04:22:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 19:07:40 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 19:08:00 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/87cbbdfb1e1ac379ffd45fe925938c749cde6ead
Cr-Commit-Position: refs/heads/master@{#36052}

Powered by Google App Engine
This is Rietveld 408576698