Include the field name and function name in Dart_GetField and Dart_Invoke timeline events

Include the field name and function name in Dart_GetField and Dart_Invoke timeline events

Fixes #26395

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/234250189b05719256aba25c588e28936f043c0b

[Cutch, 2016-05-04 14:50:15]

Description was changed from

==========
Include the field name and function name in Dart_GetField and Dart_Invoke
timeline events

BUG=
==========

to

==========
Include the field name and function name in Dart_GetField and Dart_Invoke
timeline events

Fixes #26395
==========

[Cutch, 2016-05-04 14:50:16]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[eseidel, 2016-05-04 17:49:32]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2016-05-04 17:49:32]

One question which crossed my mind when I saw these traces in the first place
was how expensive these traces are to produce?  Presumably Dart_GetField is a
rather common call?

Regardless, thank you for fixing! :D

[Cutch, 2016-05-04 17:55:14]

On 2016/05/04 17:49:32, eseidel wrote:
> One question which crossed my mind when I saw these traces in the first place
> was how expensive these traces are to produce?  Presumably Dart_GetField is a
> rather common call?
> 
> Regardless, thank you for fixing! :D

Yes, enabling the "API" timeline stream is expensive and should not be enabled
by default.

[Cutch, 2016-05-05 20:59:55]

@rmacnak *ping*

[rmacnak, 2016-05-05 23:30:54]

LGTM

https://codereview.chromium.org/1951003002/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1951003002/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:4204: const String& lib_name = String::Handle(Z,
lib.name());
This is often the empty string, consider lib.uri instead.

https://codereview.chromium.org/1951003002/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:4387: const String& lib_name =
String::Handle(lib.name());
This is often the empty string, consider lib.uri instead.

[Cutch, 2016-05-05 23:50:04]

https://codereview.chromium.org/1951003002/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1951003002/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:4204: const String& lib_name = String::Handle(Z,
lib.name());
On 2016/05/05 23:30:54, rmacnak wrote:
> This is often the empty string, consider lib.uri instead.

Done.

https://codereview.chromium.org/1951003002/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:4387: const String& lib_name =
String::Handle(lib.name());
On 2016/05/05 23:30:54, rmacnak wrote:
> This is often the empty string, consider lib.uri instead.

Done.

[Cutch, 2016-05-05 23:50:15]

Description was changed from

==========
Include the field name and function name in Dart_GetField and Dart_Invoke
timeline events

Fixes #26395
==========

to

==========
Include the field name and function name in Dart_GetField and Dart_Invoke
timeline events

Fixes #26395

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/234250189b05719256aba25c588e28936f043c0b
==========

[Cutch, 2016-05-05 23:50:17]

Committed patchset #3 (id:40001) manually as
234250189b05719256aba25c588e28936f043c0b (presubmit successful).