Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6538)

Unified Diff: chrome/browser/views/location_bar_view.h

Issue 195099: Convert InfoBubble to using BubbleBorder. This also replaces the border grap... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/info_bubble.cc ('k') | chrome/browser/views/location_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/location_bar_view.h
===================================================================
--- chrome/browser/views/location_bar_view.h (revision 26373)
+++ chrome/browser/views/location_bar_view.h (working copy)
@@ -258,7 +258,7 @@
class LocationBarImageView : public views::ImageView,
public InfoBubbleDelegate {
public:
- LocationBarImageView();
+ explicit LocationBarImageView(const BubblePositioner* bubble_positioner);
virtual ~LocationBarImageView();
// Overridden from view for the mouse hovering.
@@ -285,6 +285,10 @@
// image.
ShowInfoBubbleTask* show_info_bubble_task_;
+ // A positioner used to give the info bubble the correct target bounds. The
+ // caller maintains ownership of this and must ensure it's kept alive.
+ const BubblePositioner* bubble_positioner_;
+
DISALLOW_COPY_AND_ASSIGN(LocationBarImageView);
};
@@ -300,7 +304,9 @@
WARNING
};
- SecurityImageView(Profile* profile, ToolbarModel* model_);
+ SecurityImageView(Profile* profile,
+ ToolbarModel* model_,
+ const BubblePositioner* bubble_positioner);
virtual ~SecurityImageView();
// Sets the image that should be displayed.
@@ -341,7 +347,8 @@
public:
PageActionImageView(LocationBarView* owner,
Profile* profile,
- const PageAction* page_action);
+ const PageAction* page_action,
+ const BubblePositioner* bubble_positioner);
virtual ~PageActionImageView();
// Overridden from view for the mouse hovering.
« no previous file with comments | « chrome/browser/views/info_bubble.cc ('k') | chrome/browser/views/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698