Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: pkg/analyzer/lib/src/generated/type_system.dart

Issue 1950983004: Issue 25914. Refine type of 'T + T' when 'T extends num' to 'T' in strong mode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/type_system.dart
diff --git a/pkg/analyzer/lib/src/generated/type_system.dart b/pkg/analyzer/lib/src/generated/type_system.dart
index 426bd4c2c1d035b26b45b9d4bd99553d21a86d13..f7d0e19872f0ddf06b05c11a8fa965f0166af8c2 100644
--- a/pkg/analyzer/lib/src/generated/type_system.dart
+++ b/pkg/analyzer/lib/src/generated/type_system.dart
@@ -348,6 +348,26 @@ class StrongTypeSystemImpl extends TypeSystem {
}
@override
+ DartType refineBinaryExpressionType(
+ TypeProvider typeProvider,
+ DartType leftType,
+ TokenType operator,
+ DartType rightType,
+ DartType currentType) {
+ if (leftType is TypeParameterType &&
+ leftType.element.bound == typeProvider.numType &&
+ leftType == rightType) {
+ if (operator == TokenType.PLUS ||
+ operator == TokenType.MINUS ||
+ operator == TokenType.STAR) {
+ return leftType;
+ }
+ }
+ return super.refineBinaryExpressionType(
+ typeProvider, leftType, operator, rightType, currentType);
+ }
+
+ @override
DartType typeToConcreteType(TypeProvider typeProvider, DartType t) {
if (t is FunctionType) {
return functionTypeToConcreteType(typeProvider, t);
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698