Cleanup CFWL_ThemePart data.

Cleanup CFWL_ThemePart data.

The m_dwData pointer was being used as a generic way to pass around data. There
were only two places we were reading that data. This Cl changes to have two
specific flags and removes the generic pointer.

Committed: https://pdfium.googlesource.com/pdfium/+/b7675f63684ebff68c688a1c7b160596b6747c3e

[dsinclair, 2016-05-04 16:31:00]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-04 16:31:01]

PTAL.

https://codereview.chromium.org/1950973003/diff/1/xfa/fwl/basewidget/fwl_list...
File xfa/fwl/basewidget/fwl_listboximp.cpp (left):

https://codereview.chromium.org/1950973003/diff/1/xfa/fwl/basewidget/fwl_list...
xfa/fwl/basewidget/fwl_listboximp.cpp:650: param.m_dwData =
(uint32_t)(uintptr_t)(&itemData);
This strikes me as a bad idea given that itemData exists on stack.

https://codereview.chromium.org/1950973003/diff/1/xfa/fwl/theme/cfwl_formtp.cpp
File xfa/fwl/theme/cfwl_formtp.cpp (right):

https://codereview.chromium.org/1950973003/diff/1/xfa/fwl/theme/cfwl_formtp.c...
xfa/fwl/theme/cfwl_formtp.cpp:136: pParams->m_bMaximize, &pParams->m_matrix,
iActive);
This maybe incorrect. Should I be setting maximize true everywhere we assigned
the pointer previously?

[Tom Sepez, 2016-05-04 17:41:18]

https://codereview.chromium.org/1950973003/diff/1/xfa/fwl/theme/cfwl_formtp.cpp
File xfa/fwl/theme/cfwl_formtp.cpp (right):

https://codereview.chromium.org/1950973003/diff/1/xfa/fwl/theme/cfwl_formtp.c...
xfa/fwl/theme/cfwl_formtp.cpp:136: pParams->m_bMaximize, &pParams->m_matrix,
iActive);
On 2016/05/04 16:31:01, dsinclair wrote:
> This maybe incorrect. Should I be setting maximize true everywhere we assigned
> the pointer previously?

Heh, except when the stack was aligned to a 32bit boundary.  Might as well do
that, also the case where we set it to "i" in the loop.

[dsinclair, 2016-05-04 18:07:39]

https://codereview.chromium.org/1950973003/diff/1/xfa/fwl/theme/cfwl_formtp.cpp
File xfa/fwl/theme/cfwl_formtp.cpp (right):

https://codereview.chromium.org/1950973003/diff/1/xfa/fwl/theme/cfwl_formtp.c...
xfa/fwl/theme/cfwl_formtp.cpp:136: pParams->m_bMaximize, &pParams->m_matrix,
iActive);
On 2016/05/04 17:41:18, Tom Sepez wrote:
> On 2016/05/04 16:31:01, dsinclair wrote:
> > This maybe incorrect. Should I be setting maximize true everywhere we
assigned
> > the pointer previously?
> 
> Heh, except when the stack was aligned to a 32bit boundary.  Might as well do
> that, also the case where we set it to "i" in the loop.  

Done.

[Tom Sepez, 2016-05-04 20:47:09]

lgtm

[dsinclair, 2016-05-04 20:51:34]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-05-04 20:51:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950973003/20001

[commit-bot: I haz the power, 2016-05-04 21:11:16]

Description was changed from

==========
Cleanup CFWL_ThemePart data.

The m_dwData pointer was being used as a generic way to pass around data. There
were only two places we were reading that data. This Cl changes to have two
specific flags and removes the generic pointer.
==========

to

==========
Cleanup CFWL_ThemePart data.

The m_dwData pointer was being used as a generic way to pass around data. There
were only two places we were reading that data. This Cl changes to have two
specific flags and removes the generic pointer.

Committed:
https://pdfium.googlesource.com/pdfium/+/b7675f63684ebff68c688a1c7b160596b674...
==========

[commit-bot: I haz the power, 2016-05-04 21:11:17]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b7675f63684ebff68c688a1c7b160596b674...