Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Side by Side Diff: test/cctest/test-global-handles.cc

Issue 1950963002: Introduce a new phantom weakness type without finalization callback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/global-handles.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 } 443 }
444 444
445 CcTest::i_isolate()->heap()->CollectAllAvailableGarbage(); 445 CcTest::i_isolate()->heap()->CollectAllAvailableGarbage();
446 446
447 CHECK(!g.IsEmpty()); 447 CHECK(!g.IsEmpty());
448 v8::HandleScope scope(isolate); 448 v8::HandleScope scope(isolate);
449 v8::Local<v8::Object> o = v8::Local<v8::Object>::New(isolate, g); 449 v8::Local<v8::Object> o = v8::Local<v8::Object>::New(isolate, g);
450 CHECK_EQ(identity, o->GetIdentityHash()); 450 CHECK_EQ(identity, o->GetIdentityHash());
451 CHECK(o->Has(isolate->GetCurrentContext(), v8_str("finalizer")).FromJust()); 451 CHECK(o->Has(isolate->GetCurrentContext(), v8_str("finalizer")).FromJust());
452 } 452 }
453
454 TEST(PhatomHandlesWithoutCallbacks) {
455 CcTest::InitializeVM();
456 v8::Isolate* isolate = CcTest::isolate();
457
458 v8::Global<v8::Object> g1, g2;
459 {
460 v8::HandleScope scope(isolate);
461 g1.Reset(isolate, v8::Object::New(isolate));
462 g1.SetWeak();
463 g2.Reset(isolate, v8::Object::New(isolate));
464 g2.SetWeak();
465 }
466
467 CHECK_EQ(0, isolate->NumberOfPhantomHandleResetsSinceLastCall());
468 CcTest::i_isolate()->heap()->CollectAllAvailableGarbage();
469 CHECK_EQ(2, isolate->NumberOfPhantomHandleResetsSinceLastCall());
470 CHECK_EQ(0, isolate->NumberOfPhantomHandleResetsSinceLastCall());
471 }
OLDNEW
« no previous file with comments | « src/global-handles.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698