Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 195093004: Use invalidation sets for some pseudo elements. (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use invalidation sets for some pseudo elements. Allow to use class invalidation sets for selectors containing ::before, ::after, or ::backdrop. These pseudo elements are updated correctly in Element::recalcChildStyle for LocalStyleChange on their parents. BUG=335247 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169298

Patch Set 1 #

Patch Set 2 : Added recalc count checks to tests. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -0 lines) Patch
A LayoutTests/fast/css/dynamic-class-backdrop-pseudo.html View 1 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/dynamic-class-backdrop-pseudo-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/dynamic-class-pseudo-elements.html View 1 1 chunk +88 lines, -0 lines 1 comment Download
A LayoutTests/fast/css/dynamic-class-pseudo-elements-expected.txt View 1 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rune
6 years, 9 months ago (2014-03-11 16:59:44 UTC) #1
chrishtr
Please augment the tests to verify local style recalc happens and not subtree. Otherwise looks ...
6 years, 9 months ago (2014-03-11 17:33:09 UTC) #2
esprehn
Can you add a recalcStyle test with the count method on internals to verify the ...
6 years, 9 months ago (2014-03-11 17:40:55 UTC) #3
rune
On 2014/03/11 17:40:55, esprehn wrote: > Can you add a recalcStyle test with the count ...
6 years, 9 months ago (2014-03-12 14:53:43 UTC) #4
rune
https://codereview.chromium.org/195093004/diff/20001/LayoutTests/fast/css/dynamic-class-pseudo-elements.html File LayoutTests/fast/css/dynamic-class-pseudo-elements.html (right): https://codereview.chromium.org/195093004/diff/20001/LayoutTests/fast/css/dynamic-class-pseudo-elements.html#newcode84 LayoutTests/fast/css/dynamic-class-pseudo-elements.html:84: shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "8"); This is 8 and not 9 because ...
6 years, 9 months ago (2014-03-12 14:56:06 UTC) #5
chrishtr
lgtm
6 years, 9 months ago (2014-03-12 16:31:41 UTC) #6
esprehn
lgtm
6 years, 9 months ago (2014-03-15 05:42:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/195093004/20001
6 years, 9 months ago (2014-03-15 05:42:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-15 06:09:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-15 06:09:44 UTC) #10
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-15 07:37:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/195093004/20001
6 years, 9 months ago (2014-03-15 07:37:57 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-15 07:56:06 UTC) #13
Message was sent while issue was closed.
Change committed as 169298

Powered by Google App Engine
This is Rietveld 408576698