Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Issue 195093002: Support multiple text decoration styles. (Closed)

Created:
6 years, 9 months ago by andersr
Modified:
6 years, 9 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support multiple text decoration styles. Currently, we draw only the last seen text decoration style during decoration painting, even when multiple decorations (e.g. underline + overline) are applied. Hence, we potentially draw the wrong decoration style for one or more of the applied decorations. Fixed by fetching the matching style for each decoration, similar to how the matching text-decoration-color is fetched. BUG=351282 TEST=text-decoration-style-multiple.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -48 lines) Patch
M LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-line-expected.html View 1 chunk +5 lines, -5 lines 0 comments Download
A LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-style-multiple.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-style-multiple-expected.html View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineTextBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 5 chunks +50 lines, -30 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
andersr
6 years, 9 months ago (2014-03-11 14:44:16 UTC) #1
Stephen Chennney
LGTM. For a follow up patch, would it make the code any cleaner if you ...
6 years, 9 months ago (2014-03-11 15:22:36 UTC) #2
andersr
The CQ bit was checked by andersr@opera.com
6 years, 9 months ago (2014-03-11 16:10:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/195093002/1
6 years, 9 months ago (2014-03-11 16:10:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 16:13:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit
6 years, 9 months ago (2014-03-11 16:14:00 UTC) #6
andersr
The CQ bit was checked by andersr@opera.com
6 years, 9 months ago (2014-03-11 19:59:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/195093002/1
6 years, 9 months ago (2014-03-11 20:00:49 UTC) #8
commit-bot: I haz the power
Change committed as 168946
6 years, 9 months ago (2014-03-11 20:49:55 UTC) #9
andersr
6 years, 9 months ago (2014-03-12 16:15:55 UTC) #10
Message was sent while issue was closed.
On 2014/03/11 15:22:36, Stephen Chenney wrote:
> LGTM. For a follow up patch, would it make the code any cleaner if you break
out
> the drawing code for each of over/through/under into their own methods?

Yes, please see issue 197633002.

Powered by Google App Engine
This is Rietveld 408576698