Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: test/mjsunit/stack-traces-overflow.js

Issue 1950913004: [Interpreter] Fix bytecode offset for stack overflows. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Also fixes error-to-sttring-stack-overflow.html Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/builtins-x87.cc ('k') | tools/blink_tests/TestExpectationsIgnition » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --stack-size=100 28 // Flags: --stack-size=100
29 29
30 function overflow() {
31 var a, b, c, d, e; // Allocates some locals on the function's stack frame.
32 overflow();
33 }
30 function rec1(a) { rec1(a+1); } 34 function rec1(a) { rec1(a+1); }
31 function rec2(a) { rec3(a+1); } 35 function rec2(a) { rec3(a+1); }
32 function rec3(a) { rec2(a+1); } 36 function rec3(a) { rec2(a+1); }
33 37
38 // Test stack trace has correct function location at top of the stack.
39 try {
40 overflow();
41 } catch (e) {
42 var first_frame = e.stack.split("\n")[1]
43 assertTrue(first_frame.indexOf("stack-traces-overflow.js:30:18") > 0);
44 }
45
34 // Test stack trace getter and setter. 46 // Test stack trace getter and setter.
35 try { 47 try {
36 rec1(0); 48 rec1(0);
37 } catch (e) { 49 } catch (e) {
38 assertTrue(e.stack.indexOf("rec1") > 0); 50 assertTrue(e.stack.indexOf("rec1") > 0);
39 e.stack = "123"; 51 e.stack = "123";
40 assertEquals("123", e.stack); 52 assertEquals("123", e.stack);
41 } 53 }
42 54
43 // Test setter w/o calling the getter. 55 // Test setter w/o calling the getter.
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 assertEquals("abc", e.stack); 144 assertEquals("abc", e.stack);
133 } 145 }
134 146
135 Error.stackTraceLimit = 3; 147 Error.stackTraceLimit = 3;
136 Error = ""; // Overwrite Error in the global object. 148 Error = ""; // Overwrite Error in the global object.
137 try { 149 try {
138 rec1(0); 150 rec1(0);
139 } catch (e) { 151 } catch (e) {
140 assertEquals(4, e.stack.split('\n').length); 152 assertEquals(4, e.stack.split('\n').length);
141 } 153 }
OLDNEW
« no previous file with comments | « src/x87/builtins-x87.cc ('k') | tools/blink_tests/TestExpectationsIgnition » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698