[Interpreter] Fix bytecode offset for stack overflows.

[Interpreter] Fix bytecode offset for stack overflows.

Rather than pushing zero for the initial bytecode offset, we should push the
offset of the first bytecode handler, Smi tagged. This fixes the line number
for the top stack frame on overflow errors.

BUG=v8:4981
LOG=N

Committed: https://crrev.com/d9fd822aa27c0f1d0b7200c20945225b45ea0a6d
Cr-Commit-Position: refs/heads/master@{#36137}

[rmcilroy, 2016-05-04 21:36:17]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 21:36:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950913004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950913004/1

[rmcilroy, 2016-05-04 21:40:11]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 21:40:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950913004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950913004/20001

[rmcilroy, 2016-05-04 21:40:19]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-05-04 22:05:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 22:05:09]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-05-05 08:29:29]

rmcilroy@chromium.org changed reviewers:
+ yangguo@chromium.org

[rmcilroy, 2016-05-05 08:29:30]

Yang, please take a look, thanks.

[Yang, 2016-05-09 05:42:22]

LGTM

https://codereview.chromium.org/1950913004/diff/20001/tools/blink_tests/TestE...
File tools/blink_tests/TestExpectationsIgnition (right):

https://codereview.chromium.org/1950913004/diff/20001/tools/blink_tests/TestE...
tools/blink_tests/TestExpectationsIgnition:20: [ Linux ]
fast/dom/error-to-string-stack-overflow.html [ Failure ]
Is this not fixed too?

[rmcilroy, 2016-05-10 11:57:38]

https://codereview.chromium.org/1950913004/diff/20001/tools/blink_tests/TestE...
File tools/blink_tests/TestExpectationsIgnition (right):

https://codereview.chromium.org/1950913004/diff/20001/tools/blink_tests/TestE...
tools/blink_tests/TestExpectationsIgnition:20: [ Linux ]
fast/dom/error-to-string-stack-overflow.html [ Failure ]
On 2016/05/09 05:42:22, Yang wrote:
> Is this not fixed too?

It does indeed, done.

[rmcilroy, 2016-05-10 11:57:43]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-05-10 11:57:43]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1950913004/#ps40001
(title: "Also fixes error-to-sttring-stack-overflow.html")

[commit-bot: I haz the power, 2016-05-10 11:57:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950913004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950913004/40001

[commit-bot: I haz the power, 2016-05-10 12:29:19]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-10 12:30:15]

Description was changed from

==========
[Interpreter] Fix bytecode offset for stack overflows.

Rather than pushing zero for the initial bytecode offset, we should push the
offset of the first bytecode handler, Smi tagged. This fixes the line number
for the top stack frame on overflow errors.

BUG=v8:4981
LOG=N
==========

to

==========
[Interpreter] Fix bytecode offset for stack overflows.

Rather than pushing zero for the initial bytecode offset, we should push the
offset of the first bytecode handler, Smi tagged. This fixes the line number
for the top stack frame on overflow errors.

BUG=v8:4981
LOG=N

Committed: https://crrev.com/d9fd822aa27c0f1d0b7200c20945225b45ea0a6d
Cr-Commit-Position: refs/heads/master@{#36137}
==========

[commit-bot: I haz the power, 2016-05-10 12:30:17]

Patchset 2 (id:??) landed as
https://crrev.com/d9fd822aa27c0f1d0b7200c20945225b45ea0a6d
Cr-Commit-Position: refs/heads/master@{#36137}