src/pdf/SkPDFShader.cpp - Issue 19509005: If we fail to contruct the Pdf Image Shader, mark the object as busted, and dn't try to remove it f…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFShader.cpp

Issue 19509005: If we fail to contruct the Pdf Image Shader, mark the object as busted, and dn't try to remove it f… (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/pdf/SkPDFShader.cpp

===================================================================

--- src/pdf/SkPDFShader.cpp (revision 10286)

+++ src/pdf/SkPDFShader.cpp (working copy)

@@ -444,7 +444,9 @@

public:

explicit SkPDFImageShader(SkPDFShader::State* state);

virtual ~SkPDFImageShader() {

- RemoveShader(this);

+ if (isValid()) {

+ RemoveShader(this);

+ }

fResources.unrefAll();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »