Source/core/inspector/InspectorDOMAgent.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/RadioNodeList.cpp ('K') | « Source/core/html/shadow/TextFieldDecorationElement.cpp ('k') | Source/core/loader/FormSubmission.cpp » ('j') | Source/core/page/DragController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp

index a2416f15d12cc8ed74f8facf388f1dfc3d7f9f0a..3c4e22a525d787a248ddcc7e83e4c65312868dd6 100644

--- a/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/Source/core/inspector/InspectorDOMAgent.cpp

@@ -1282,7 +1282,7 @@ void InspectorDOMAgent::setFileInputFiles(ErrorString* errorString, int nodeId,

Node* node = assertNode(errorString, nodeId);

if (!node)

return;

- HTMLInputElement* element = node->toInputElement();

+ Handle<HTMLInputElement> element = node->toInputElement();

if (!element || !element->isFileUpload()) {

*errorString = "Node is not a file input element";

return;