Source/core/html/HTMLOptionsCollection.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLOptionsCollection.cpp

diff --git a/Source/core/html/HTMLOptionsCollection.cpp b/Source/core/html/HTMLOptionsCollection.cpp

index 9be4ba096f0b3f7ce8fc0e944acb11ee53638ae8..f36d18faf0c437be0c5cb108c6bfa9361a8718f5 100644

--- a/Source/core/html/HTMLOptionsCollection.cpp

+++ b/Source/core/html/HTMLOptionsCollection.cpp

@@ -59,7 +59,7 @@ void HTMLOptionsCollection::add(PassRefPtr<HTMLOptionElement> element, int index

}

ec = 0;

- HTMLSelectElement* select = toHTMLSelectElement(ownerNode());

+ Handle<HTMLSelectElement> select = toHTMLSelectElement(ownerNode());

if (index == -1 || unsigned(index) >= length())

select->add(newOption, 0, ec);

« Source/core/html/HTMLInputElement.h ('K') | « Source/core/html/HTMLOptionElement.cpp ('k') | Source/core/html/HTMLOutputElement.h » ('j') | Source/core/html/InputType.h » ('J')