Source/core/editing/ReplaceSelectionCommand.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/accessibility/AccessibilitySlider.cpp ('K') | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/html/BaseButtonInputType.h » ('j') | Source/core/html/BaseButtonInputType.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 494a4653907afbeb3e77e7511e2ef5474e1332b3..0d9bfd2e58d900467d936fccf4f962b0cdc928ba 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -1250,7 +1250,7 @@ bool ReplaceSelectionCommand::shouldPerformSmartReplace() const

if (!m_smartReplace)

return false;

- Element* textControl = enclosingTextFormControl(positionAtStartOfInsertedContent().deepEquivalent());

+ Element* textControl = Handle<HTMLTextFormControlElement>(enclosingTextFormControl(positionAtStartOfInsertedContent().deepEquivalent())).raw();

if (textControl && textControl->hasTagName(inputTag) && static_cast<HTMLInputElement*>(textControl)->isPasswordField())

return false; // Disable smart replace for password fields.